1364196 - Build stats perfherder metrics don't include extra options

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Gregory Szorc [:gps]]

_generate_build_stats() in buildbase.py isn't adding the perfherder_extra_options config option into perfherder metrics. This means many metrics are bi-modal. e.g. https://treeherder.mozilla.org/perf.html#/graphs?series=%5Bautoland,c76f3723c54793e567e8bee9fecd29ab1954543c,1,2%5D&selected=%5Bautoland,c76f3723c54793e567e8bee9fecd29ab1954543c,202855,98483475%5D

In this case, the two lines come from the vanilla config and static analysis I think.

This should be a trivial patch.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1364196 - Clean up code adding "nightly" to perfherder data;

I like fewer lines of code.

Review commit: https://reviewboard.mozilla.org/r/138550/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138550/

Comment 2

[Gregory Szorc [:gps]]

Attachment: Bug 1364196 - Ensure perfherder_extra_options always present;

Previously, only the mach resource metrics consulted
perfherder_extra_options. This resulted in many data sets tracking
values for distinct build configurations.

Review commit: https://reviewboard.mozilla.org/r/138552/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138552/

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8866941 [details]
Bug 1364196 - Clean up code adding "nightly" to perfherder data;

https://reviewboard.mozilla.org/r/138550/#review141808

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8866942 [details]
Bug 1364196 - Ensure perfherder_extra_options always present;

https://reviewboard.mozilla.org/r/138552/#review141810

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fda6d4c274b7
Clean up code adding "nightly" to perfherder data; r=ted
https://hg.mozilla.org/integration/autoland/rev/bec79e23bdac
Ensure perfherder_extra_options always present; r=ted

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fda6d4c274b7
https://hg.mozilla.org/mozilla-central/rev/bec79e23bdac