Closed Bug 1364211 Opened 7 years ago Closed 7 years ago

Correct Variable scope in TestSize class for start_size variable

Categories

(Remote Protocol :: Marionette, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: automatedtester, Assigned: tiago, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=py])

Attachments

(1 file)

The variable is scoped against `self` and not in the `setup()` method in https://dxr.mozilla.org/mozilla-central/source/testing/marionette/harness/marionette_harness/tests/unit/test_window_rect.py#124-125

These need to have the `self.` removed

To get started, follow the details in https://wiki.mozilla.org/User:Mjzffr/New_Contributors
Comment on attachment 8867577 [details]
Bug 1364211 - Correct variable scope in TestSize class for start_size variable.

https://reviewboard.mozilla.org/r/139122/#review142484
Attachment #8867577 - Flags: review?(dburns) → review+
Thanks for the patch!
Assignee: nobody → tiago.paez11
Pushed by dburns@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec72e5d8e6c8
Correct variable scope in TestSize class for start_size variable. r=automatedtester
https://hg.mozilla.org/mozilla-central/rev/ec72e5d8e6c8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: