Closed Bug 1364241 Opened 3 years ago Closed 3 years ago

Handle empty transactions with BlobImages

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

Attachments

(1 file)

No description provided.
Blocks: 1362115
Assignee: nobody → jmuizelaar
Attachment #8867000 - Flags: review?(mchang)
Comment on attachment 8867000 [details] [diff] [review]
Handle empty transactions by keeping around the blob data

Review of attachment 8867000 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/wr/WebRenderPaintedLayerBlob.cpp
@@ +81,1 @@
>    } else {

nit: assert mImageKey.isSome()? Also just leave in the commnet we reuse the blob image?
Attachment #8867000 - Flags: review?(mchang) → review+
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/d4ffcd51dcf4
Handle empty transactions by keeping around the blob data. r=mchang
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.