Stylo: visited support for lazy pseudo-elements

RESOLVED FIXED in Firefox 56

Status

()

Core
CSS Parsing and Computation
P2
normal
RESOLVED FIXED
3 months ago
20 days ago

People

(Reporter: jryans, Assigned: bz)

Tracking

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 months ago
After bug 1328509, we'll have visited support primary elements and eager pseudos.

Gecko also supports them for lazy pseudos, so we'll add that part here.
Assignee: nobody → jryans
Priority: -- → P2
(Reporter)

Comment 1

2 months ago
This should fix at least:

layout/reftests/css-visited/color-on-bullets-1.html
(Reporter)

Comment 2

27 days ago
:bz is working on this.
Assignee: jryans → bzbarsky
(Assignee)

Comment 3

26 days ago
Created attachment 8882498 [details] [diff] [review]
tests

MozReview-Commit-ID: 3rgvgoRY1lc
Attachment #8882498 - Flags: review?(jryans)
(Reporter)

Comment 4

25 days ago
Comment on attachment 8882498 [details] [diff] [review]
tests

Review of attachment 8882498 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for working on this, looks great to me! :)
Attachment #8882498 - Flags: review?(jryans) → review+

Comment 5

25 days ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d7c81dce6e2a
tests.  r=jryans

Comment 6

25 days ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c1e7f75a445
followup: we pass caret-color-on-visited now as well.
https://hg.mozilla.org/mozilla-central/rev/d7c81dce6e2a
https://hg.mozilla.org/mozilla-central/rev/8c1e7f75a445
Status: NEW → RESOLVED
Last Resolved: 24 days ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
(Reporter)

Updated

20 days ago
Blocks: 1371036
You need to log in before you can comment on or make changes to this bug.