1364303 - stylo: need support for CSS_PSEUDO_CLASS_ENABLED_IN_UA_SHEETS_AND_CHROME on pseudo-classes

Status: RESOLVED DUPLICATE of bug 1381851

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Gecko pseudo-classes can be enabled in one of three places:

1)  Everywhere (no flags)
2)  In UA sheets only (CSS_PSEUDO_CLASS_ENABLED_IN_UA_SHEETS)
3)  In UA sheets and chrome sheets (CSS_PSEUDO_CLASS_ENABLED_IN_UA_SHEETS_AND_CHROME)

What stylo seems to have, in non_ts_pseudo_class_list is a single flag (PSEUDO_CLASS_INTERNAL) whose behavior, I think, corresponds to CSS_PSEUDO_CLASS_ENABLED_IN_UA_SHEETS.  There seems to be no equivalent of CSS_PSEUDO_CLASS_ENABLED_IN_UA_SHEETS_AND_CHROME.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Are we going to support chrome document in Stylo's MVP? If not, I guess this isn't a high priority thing.

Comment 2

[Boris Zbarsky [:bzbarsky]]

> Are we going to support chrome document in Stylo's MVP?

The question isn't whether we support chrome _document's_ but whether we support chrome _stylesheets_.

We're certainly going to support some of those (e.g. chrome://global/skin/resizer.css better be supported).  The question is whether any of them use the relevant pseudo-classes.

Just did some spot-checking, and looks to me like :-moz-handler-crashed is used in the pluginproblem bits, and those sheets are pulled into random content documents as needed.

Comment 3

[Cameron McCormack (:heycam)]

TY's doing this as part of bug 1381851.

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

The patches in bug 1381851 has implemented PSEUDO_CLASS_ENABLED_IN_UA_SHEETS_AND_CHROME, so mark this bug as a dup.