1364342 - mailnews/db/gloda/modules/indexer.js causes [System Principal] atom leak

Status: NEW

(MailNews Core :: Backend, defect)

Description

[Jorg K (CEST = GMT+2)]

Attachment: report-atom-leaks.patch

+++ This bug was initially created as a clone of Bug #1342745 +++

See bug 1342745 comment #21:

I commented out
this._idleService.addIdleObserver(this, this._indexIdleThresholdSecs);
and
this._idleService.removeIdleObserver(this, this._indexIdleThresholdSecs);
and the leak is gone!

To see the leak one needs to enable it in xpcom/ds/nsAtomTable.cpp as per the attached patch.

For the record (for myself) from bug 1334771 comment #12, this is the command:
$ obj-x86_64-pc-mingw32/dist/bin/xpcshell.exe -g obj-x86_64-pc-mingw32/dist/bin/ -a obj-x86_64-pc-mingw32/dist/bin/ -f mozilla/toolkit/mozapps/installer/precompile_cache.js -e 'precompile_startupcache("resource://gre/");'

Comment 1

[Jorg K (CEST = GMT+2)]

Looking at bug 1342745 comment #22, the M-C test dom/presentation/tests/xpcshell/test_multicast_dns_device_provider.js already causes a leak of the "[System Principal]" atom.

Comment 2

[Boris Zbarsky [:bzbarsky]]

My recommendation would be that this code register as a shutdown observer (since it's registering as an observer anyway) and when it gets a shutdown notification unregister as an idle observer.