1364635 - Don't offer to configure Mercurial if running from a git checkout

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Gregory Szorc [:gps]]

Today, `mach bootstrap` prompts you to configure Mercurial even if running from a Git checkout. I don't think that makes sense.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1364635 - Don't offer to configure Mercurial if running from a Git checkout;

Previously, `mach bootstrap` would unconditionally prompt to help
configure Mercurial in most scenarios. I agree with Ehsan's observation
in a mailing list post that this behavior doesn't make sense when
running from a Git checkout, as the user probably doesn't care about
Mercurial if they are using Git.

Review commit: https://reviewboard.mozilla.org/r/138972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138972/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8867430 [details]
Bug 1364635 - Don't offer to configure Mercurial if running from a Git checkout;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138972/diff/1-2/

Comment 3

[(no longer active)]

Comment on attachment 8867430 [details]
Bug 1364635 - Don't offer to configure Mercurial if running from a Git checkout;

https://reviewboard.mozilla.org/r/138972/#review142288

Thanks a lot!

::: commit-message-e76ee:15
(Diff revision 2)
> +example, we still unconditionally run code that verifies that Mercurial
> +is installed and reasonably up to date. However, refactoring that is
> +a bit of work. I figure something is better than nothing. At least
> +with this patch `mach bootstrap` for users with a Gecko checkout
> +doesn't say anything about Mercurial if a modern Mercurial is
> +installed.

I think this is a great improvement, and the fact that this part is left in is in fact desirable since you'd typically be using git-cinnabar so ensuring having an hg installation makes sense.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8867430 [details]
Bug 1364635 - Don't offer to configure Mercurial if running from a Git checkout;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138972/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3aab38317ccd
Don't offer to configure Mercurial if running from a Git checkout; r=Ehsan

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3aab38317ccd