SeaMonkey location bar broken after bug 1353542 [Switch to async/await from Task.jsm/yield]

RESOLVED FIXED in seamonkey2.52

Status

SeaMonkey
Location Bar
P1
blocker
RESOLVED FIXED
10 months ago
9 months ago

People

(Reporter: frg, Assigned: frg)

Tracking

Trunk
seamonkey2.52
All
Unspecified
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.52 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
The location bar currently does nothing in nightly builds. You see errors that Task calls are undefinied in the error console.

task.jsm was removed in many places in bug 1353542 and previously not included in navigator.js.

The changes to browser.js should be ported to navigator.js.
(Assignee)

Comment 1

10 months ago
Created attachment 8867467 [details] [diff] [review]
1364677-task.patch

Fixes error with the location bar. Drag and drop also still works.

FYI. The follwing error is still in the build but was caused by bug 1157709.

> Error: PlacesUtils.asyncGetBookmarkIds is not a function
> Source File: chrome://communicator/content/bookmarks/browser-places.js
> Line: 728

One patch at a time:)
Attachment #8867467 - Flags: review?(iann_bugzilla)
(Assignee)

Updated

10 months ago
Blocks: 1345770
I have a sort of hunch that this bug is what makes the Keyword Search extension inoperative in the current trunk builds. Let's CC it's author.

Comment 3

9 months ago
Comment on attachment 8867467 [details] [diff] [review]
1364677-task.patch

LGTM r=me
Attachment #8867467 - Flags: review?(iann_bugzilla) → review+

Updated

9 months ago
Depends on: 1353542
Comment on attachment 8867467 [details] [diff] [review]
1364677-task.patch

frg: I tried your experimental build http://www.pinballz.net/custom/frg/seamonkey-2.52a1.en-US.linux-x86_64.tar.bz2 with attachment 8867467 [details] [diff] [review] patched in as well as attachment 8869326 [details] [diff] [review] for bug 1363036.

1°) in a fresh profile, no customizations.
- Starts with default theme (but Modern can be enabled) and Lightning disabled app-global (but can be enabled). cZ, DOMi and DebugQA are enabled in the profile.
- Location bar works.

2°) in my usual profile with 542 tabs and a lot of extensions
- Does not exhibit crash bug 1363036.
- Location bar works.
- Keyword Search extension (which this bug disabled) works again.
- Saved session, current themes (both complete and lightweight), userC*.css etc. are correctly remembered from when I last used this profile. 
- Works "just as well" as the 12 May nightly (built before this bug appeared) AFAICT

UA:"Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 SeaMonkey/2.52a1" 
ID:20170521130302 en-US 
c-c:9285e79dfd098b4d5e6de6c12550e72c98387ce4 
m-c:5b74bbf20e803e299790d266fc6ebf5d53b7a1b7
Attachment #8867467 - Flags: feedback+
(Assignee)

Comment 5

9 months ago
https://hg.mozilla.org/comm-central/rev/6d1a2620707e6fbd7419bba3b03cffbc5e95b227
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-seamonkey2.52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.52
You need to log in before you can comment on or make changes to this bug.