[MediaRecorder] requestData fails if called on a paused recorder

RESOLVED FIXED in Firefox 55

Status

()

P2
normal
Rank:
25
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bryce, Assigned: bryce)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Calling requestData[1] on a paused recorder currently throws an invalid state error. Based on the spec[1] I believe this is a valid operation, and we should only throw if the element is inactive. As such, I propose reworking the current check[2] to be more permissive.

[1]: https://w3c.github.io/mediacapture-record/MediaRecorder.html#dom-mediarecorder-requestdata
[2]: https://dxr.mozilla.org/mozilla-central/source/dom/media/MediaRecorder.cpp?q=MediaRecorder.cpp&redirect_type=direct#1140
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8867563 [details]
Bug 1364776 - Relax the restrictions on when MediaRecorder.requestData can be called.

https://reviewboard.mozilla.org/r/139102/#review142430
Attachment #8867563 - Flags: review?(pehrson) → review+
Assignee: nobody → bvandyk
Status: NEW → ASSIGNED
Rank: 25
Priority: -- → P2

Comment 3

a year ago
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3cbe9b541b39
Relax the restrictions on when MediaRecorder.requestData can be called. r=pehrsons

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3cbe9b541b39
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.