1364776 - [MediaRecorder] requestData fails if called on a paused recorder

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, enhancement, P2)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Calling requestData[1] on a paused recorder currently throws an invalid state error. Based on the spec[1] I believe this is a valid operation, and we should only throw if the element is inactive. As such, I propose reworking the current check[2] to be more permissive.

[1]: https://w3c.github.io/mediacapture-record/MediaRecorder.html#dom-mediarecorder-requestdata
[2]: https://dxr.mozilla.org/mozilla-central/source/dom/media/MediaRecorder.cpp?q=MediaRecorder.cpp&redirect_type=direct#1140

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1364776 - Relax the restrictions on when MediaRecorder.requestData can be called.

Review commit: https://reviewboard.mozilla.org/r/139102/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139102/

Comment 2

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8867563 [details]
Bug 1364776 - Relax the restrictions on when MediaRecorder.requestData can be called.

https://reviewboard.mozilla.org/r/139102/#review142430

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cbe9b541b39
Relax the restrictions on when MediaRecorder.requestData can be called. r=pehrsons

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3cbe9b541b39