Closed Bug 1364776 Opened 3 years ago Closed 3 years ago

[MediaRecorder] requestData fails if called on a paused recorder

Categories

(Core :: Audio/Video: Recording, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bryce, Assigned: bryce)

Details

Attachments

(1 file)

Calling requestData[1] on a paused recorder currently throws an invalid state error. Based on the spec[1] I believe this is a valid operation, and we should only throw if the element is inactive. As such, I propose reworking the current check[2] to be more permissive.

[1]: https://w3c.github.io/mediacapture-record/MediaRecorder.html#dom-mediarecorder-requestdata
[2]: https://dxr.mozilla.org/mozilla-central/source/dom/media/MediaRecorder.cpp?q=MediaRecorder.cpp&redirect_type=direct#1140
Comment on attachment 8867563 [details]
Bug 1364776 - Relax the restrictions on when MediaRecorder.requestData can be called.

https://reviewboard.mozilla.org/r/139102/#review142430
Attachment #8867563 - Flags: review?(pehrson) → review+
Assignee: nobody → bvandyk
Status: NEW → ASSIGNED
Rank: 25
Priority: -- → P2
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3cbe9b541b39
Relax the restrictions on when MediaRecorder.requestData can be called. r=pehrsons
https://hg.mozilla.org/mozilla-central/rev/3cbe9b541b39
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.