1364830 - Fix image flags for background image layer

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

The wrong image flags and wrong draw result cause the image disappearing issue. I will fix it.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Fix background image layer's draw result and image flags

In this patch, I correct the draw result of background image layer and also correct the image flags. The try result[1] doesn't have image disappearing issue. I also check the original gecko try[2] without the pref on, and the result looks fine.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=30cc3fb4f2469e2b446390841213de93777b0a9e&selectedJob=99068440

[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=de5b94a1b9e5924c333c5631f1eec29953724a8c

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8867638 [details] [diff] [review]
Fix background image layer's draw result and image flags

Review of attachment 8867638 [details] [diff] [review]:
-----------------------------------------------------------------

r=me without the gradient change.

::: layout/painting/nsCSSRendering.cpp
@@ +1983,5 @@
>      }
>    }
>  
>    // We only support painting gradients and image for a single style image layer
> +  return //styleImage->GetType() == eStyleImageType_Gradient ||

Why are you disabling gradients?

Comment 3

[Ethan Lin[:ethlin]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #2)
> Comment on attachment 8867638 [details] [diff] [review]
> Fix background image layer's draw result and image flags
> 
> Review of attachment 8867638 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me without the gradient change.
> 
> ::: layout/painting/nsCSSRendering.cpp
> @@ +1983,5 @@
> >      }
> >    }
> >  
> >    // We only support painting gradients and image for a single style image layer
> > +  return //styleImage->GetType() == eStyleImageType_Gradient ||
> 
> Why are you disabling gradients?

Oh...That's for test. I will remove this change.

Comment 4

[Ethan Lin[:ethlin]]

Attachment: Fix background image layer's draw result and image flags (carry r+: mattwoodrow)

Remove the test code.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/65542e1d8eae
Fix background image layer's draw result and image flags. r=mattwoodrow

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/65542e1d8eae