stylo: add support for a "re-run selector matching on children only" restyle hint

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This is something that Gecko doesn't do (though could), but I had written down in my notes, and wasn't too hard.
(Assignee)

Updated

2 years ago
Blocks: 1366194
Comment hidden (mozreview-request)
(Assignee)

Comment 4

2 years ago
Actually I'm not sure if these adjustments are needed due to this bug, or bug 1289868, since I've been testing them together.

Filed bug 1366206 for the MathML one.  399384-1.html is a ::first-line test, so don't put too much stock in it passing now.

For the test_transitions_and_reframes.html failures, it's this:

TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_and_reframes.html | margin of child of element b2 (classes: t m o) ::before pseudo-element - got "100px", expected "25px"
TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_and_reframes.html | margin of child of element a2 (classes: t m o) ::after pseudo-element - got "100px", expected "25px"
TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_and_reframes.html | margin of child of element b2 (classes: m o t) ::before pseudo-element - got "100px", expected "25px"
TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_and_reframes.html | margin of child of element a2 (classes: m o t) ::after pseudo-element - got "100px", expected "25px" 

Given the current implementation state of transitions and pseudo-elements, do you think it's not unexpected that this could start failing?  If you think I should look into this, I can, though I'd rather land these patches first since it's taken me a while to get them to the point of being landable and don't want to do any more rebasing. :-)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8869371 [details]
Bug 1364845 - stylo: Adjust test expectations.

https://reviewboard.mozilla.org/r/141018/#review144592

I think the transitions in pseudo-element tests are worth looking into, since when I was writing bug 1331047 the failures revealed some legit bugs.

That being said, I think it's fine to investigate them as a followup, so r=me with a followup bug referenced from the expectations file.
Attachment #8869371 - Flags: review?(emilio+bugs) → review+
Comment hidden (mozreview-request)

Comment 8

2 years ago
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/36678242b5a6
stylo: Adjust test expectations. r=emilio

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/36678242b5a6
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Assignee)

Updated

2 years ago
Assignee: nobody → cam
You need to log in before you can comment on or make changes to this bug.