136485 - button text does not appear

Status: RESOLVED WORKSFORME

(www.mozilla.org :: General, defect)

Description

[Brant Gurganus]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.9+)
Gecko/20020408
BuildID:    2002040803

According to http://www.mozilla.org/projects/xul/tests/buttons.xul, there should
be text in the final set of buttons.  This is not the case.

Reproducible: Always
Steps to Reproduce:
1. Load http://www.mozilla.org/projects/xul/tests/buttons.xul.

Actual Results:  The final row of buttons do not have text in them.

Expected Results:  Appropriate text appears in those buttons.

Comment 1

[Brant Gurganus]

filed in wrong component

Comment 2

[rods (gone)]

-->

Comment 3

[Stephan Hohe]

Confirming with Win98SE, Build 20020410(03)

Comment 4

[Stephan Hohe]

Confirming for  Win98SE, Build 20020410(03)

Comment 5

[R.K.Aa.]

*** Bug 141655 has been marked as a duplicate of this bug. ***

Comment 6

[Brant Gurganus]

Changed OS since this happened on 98 as well.

Comment 7

[Boris Zbarsky [:bzbarsky]]

This is not an XUL bug, but a bug in the testcase.  The testcase needs to be
updated to the new <dialog> syntax; <window> no longer puts magic labels on buttons.

Comment 8

[Brant Gurganus]

Changing to correct component owner/QA

Comment 9

[Brant Gurganus]

reassigning to creator/editor from CVS log at
http://www.mozilla.org/webtools/bonsai/cvslog.cgi?file=mozilla-org//html/projects/xul/tests/buttons.xul&rev=&root=/cvsroot/

Comment 10

[Daniel Wang]

it seems to be that dlgtype will be respected if:
  1) the file is in chrome:
  2) and the window is <dialog>, not <window>

if so, we need to move the file to Mozilla source tree

@@ -23,7 +23,7 @@
 
 <?xml-stylesheet href="chrome://global/skin/" type="text/css"?> 
 
-<dialog id="main-window" xmlns:html="http://www.w3.org/1999/xhtml"
+<window id="main-window" xmlns:html="http://www.w3.org/1999/xhtml"
         xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
         onload="testElt(document.getElementById('testelt'));" orient="vertical"
style="padding: 8px;">
   <script>
@@ -200,4 +200,4 @@
     <button dlgtype="disclosure"/>
   </hbox>
 
-</dialog>
\ No newline at end of file
+</window>
\ No newline at end of file

Comment 11

[Anne (:annevk)]

It uses the WINDOWS element.

-> WORKSFORME