1364851 - gfx/2d/DrawTargetSkia.cpp:1982:12: error: aggregate 'SkRegion region' has incomplete type and cannot be defined

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jan Beich]

OpenBSD and NetBSD still default to --disable-skia-gpu which was recently broken.

gfx/2d/DrawTargetSkia.cpp:1982:12: error: variable has incomplete type 'SkRegion'
  SkRegion region;
           ^
gfx/skia/skia/include/core/SkCanvas.h:39:7: note: forward declaration of 'SkRegion'
class SkRegion;
      ^
gfx/2d/DrawTargetSkia.cpp:1984:44: error: incomplete type 'SkRegion' named in nested name
      specifier
    region.op(IntRectToSkIRect(aRects[i]), SkRegion::kUnion_Op);
                                           ^~~~~~~~~~
gfx/skia/skia/include/core/SkCanvas.h:39:7: note: forward declaration of 'SkRegion'
class SkRegion;
      ^
2 errors generated.

http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/2085/steps/build/logs/stdio
http://searchfox.org/mozilla-central/rev/484d2b7f51b7/toolkit/moz.configure#962

Comment 1

[Jan Beich]

Other platforms rely on header bootlegging:

In file included from gfx/2d/DrawTargetSkia.cpp:34:
In file included from gfx/skia/skia/src/gpu/GrRenderTargetContext.h:13:
In file included from gfx/skia/skia/src/gpu/GrPaint.h:18:
gfx/skia/skia/include/core/SkRegion.h:30:2: error: test

Comment 2

[Jan Beich]

Attachment: Bug 1364851 - Explicitly include SkRegion.h for --disable-skia-gpu.

Review commit: https://reviewboard.mozilla.org/r/139238/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139238/

Comment 3

[Lee Salzman [:lsalzman]]

Comment on attachment 8867644 [details]
Bug 1364851 - Explicitly include SkRegion.h for --disable-skia-gpu.

https://reviewboard.mozilla.org/r/139238/#review142556

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e581926e034
Explicitly include SkRegion.h for --disable-skia-gpu. r=lsalzman

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9e581926e034