1364880 - stylo: The style we return when resolving a pseudo style that doesn't match any rules looks fishy.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Emilio Cobos Álvarez (:emilio)]

We return the element style, and I think we should, if only, return a style inheriting from it, instead.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Simple testcase showing incorrect behavior:

  <div style="position: absolute"></div>
  <script>
    alert(getComputedStyle(document.querySelector("div"), "::before").position);
  </script>

alerts "absolute", which is wrong; should be "static".

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1364880: Test non-existent pseudo-element styles.

Review commit: https://reviewboard.mozilla.org/r/152360/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152360/

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8881003 [details]
Bug 1364880: Test non-existent pseudo-element styles.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152360/diff/1-2/

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8881003 [details]
Bug 1364880: Test non-existent pseudo-element styles.

https://reviewboard.mozilla.org/r/152360/#review157418

::: testing/web-platform/tests/cssom/getComputedStyle-pseudo.html:48
(Diff revision 2)
> +test(function() {
> +  var has_no_pseudos = document.body;
> +  has_no_pseudos.style.position = "relative";
> +  [":before", ":after"].forEach(function(pseudo) {
> +    assert_equals(getComputedStyle(has_no_pseudos, pseudo).position, "static",
> +                  "Unexisting " + pseudo + " pseudo-element shouldn't claim to have " +

s/Unexisting/Nonexistent/

and the same in the test description string.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8881003 [details]
Bug 1364880: Test non-existent pseudo-element styles.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152360/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef997eeca061
Test non-existent pseudo-element styles. r=bz

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ef997eeca061