Closed
Bug 1364898
Opened 8 years ago
Closed 6 years ago
Generate process enums & strings from Processes.yaml
Categories
(Toolkit :: Telemetry, enhancement, P3)
Toolkit
Telemetry
Tracking
()
RESOLVED
DUPLICATE
of bug 1361661
People
(Reporter: gfritzsche, Unassigned)
References
Details
Attachments
(1 file)
26.78 KB,
patch
|
Details | Diff | Splinter Review |
- use Processes.yaml to specify:
- the payload processes names
- "internal" enum names
- (also the valid record_in_processes names?)
- generate headers with enums and strings at build time
- refactor histograms/scalars/events to use these common headers
Reporter | ||
Comment 1•8 years ago
|
||
Reporter | ||
Comment 2•8 years ago
|
||
(In reply to Georg Fritzsche [:gfritzsche] from comment #0)
> - use Processes.yaml to specify:
> - the payload processes names
> - "internal" enum names
> - (also the valid record_in_processes names?)
> - generate headers with enums and strings at build time
> - refactor histograms/scalars/events to use these common headers
Also:
The C++-to-JS serializations can already use the right payload names (or look them up in a single table), so we could remove the hardcoded name mappings from TelemetrySession.jsm and aboutTelemetry.js.
Comment 3•6 years ago
|
||
Looks like this was taken care of in bug 1361661 ?
Evidence: https://searchfox.org/mozilla-central/source/__GENERATED__/toolkit/components/telemetry/TelemetryProcessData.h
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•