Closed
Bug 1364957
Opened 8 years ago
Closed 6 years ago
FX_PAGE_LOAD_MS_2 has broken check for about: scheme
Categories
(Firefox :: General, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox 65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: Gijs, Assigned: tdsmith)
References
Details
Attachments
(1 file)
https://dxr.mozilla.org/mozilla-central/rev/e66dedabe582ba7b394aee4f89ed70fe389b3c46/browser/base/content/browser.js#5062
if (aWebProgress.isTopLevel && (!aRequest.originalURI || aRequest.originalURI.spec.scheme != "about")) {
'uri.spec.scheme' makes no sense. It should be 'uri.scheme'. This has been broken since implemented in bug 1228020, so AFAICT we're not currently ignoring about: schemes for FX_PAGE_LOAD at all, as the check always passes.
|
Assignee | |
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
|
|
Assignee | |
Comment 2•6 years ago
|
||
Actually, it looks like I messed up somehow and dropped the commit for the fix :| I'll take this on, though.
Assignee: nobody → tdsmith
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
|
|
Assignee | |
Comment 3•6 years ago
|
||
We should be ignoring about: URIs for the page load time metric, since they load very quickly
and aren't representative of Web page load times.
|
||
Updated•6 years ago
|
Summary: FX_PAGE_LOAD_MS has broken check for about: scheme → FX_PAGE_LOAD_MS_2 has broken check for about: scheme
Pushed by tismith@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/729cedad7137
Fix about: scheme check for FX_PAGE_LOAD_MS_2 r=Gijs
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in
before you can comment on or make changes to this bug.
Description
•