Closed Bug 136498 Opened 22 years ago Closed 22 years ago

Add GB18030 to mail compose menu item

Categories

(MailNews Core :: Internationalization, defect)

Product:
MailNews Core
Component:
Internationalization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: nhottanscp, Assigned: nhottanscp)

References

Details

(Keywords: intl, Whiteboard: [adt2] [Needs a=])

Attachments

(1 file)

Add GB18030 to mail compose charset menu.
1.36 KB, patch
tetsuroy
: review+
alecf
: superreview+
jesup
: approval+
Details | Diff | Splinter Review 
Add GB18030 to mail compose menu item.
could we fix this for rtm?
it should be easy, just add "gb18030, " to 
http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/locale/en-US/navigator.properties#29

intl.charsetmenu.mailedit=ISO-8859-1, ISO-8859-15, ISO-8859-6, armscii-8,
geostd8, ISO-8859-13, ISO-8859-14, ISO-8859-2, GB2312, Big5, KOI8-R,
windows-1251, KOI8-U, ISO-8859-7, ISO-8859-8-I, ISO-2022-JP, EUC-KR,
ISO-8859-10, ISO-8859-3, TIS-620, ISO-8859-9, UTF-8, VISCII

after "GB2312, "

remember to change the ns version too.
Keywords: intl, nsbeta1
nsbeta1+, we need this for rtm
Keywords: nsbeta1 → nsbeta1+
Whiteboard: [adt2]
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0.1
Comment on attachment 81921 [details] [diff] [review]
Add GB18030 to mail compose charset menu.

/r=yokoyama
Simple patch.
Attachment #81921 - Flags: review+
Comment on attachment 81921 [details] [diff] [review]
Add GB18030 to mail compose charset menu.

sr=alecf
Attachment #81921 - Flags: superreview+
Blocks: 141008
checked in to the turnk (mozilla and ns)
No longer blocks: 141008
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Blocks: 141008
ji@netscape.com:
Please verify on trunk and mark it as verified if that is the case. We need that
to ask adt to consider this for rtm.
Blocks: 143047
Keywords: adt1.0.0, approval
Whiteboard: [adt2] → [adt2] [Needs a=]
Verified as fixed on 05/13 trunk build.
Status: RESOLVED → VERIFIED
adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch.  Please
get drivers a= again, since their previous approval is more than 3 days old. 
After, checking in, please add the fixed1.0 keyword.
Keywords: adt1.0.0 → adt1.0.0+
changing to adt1.0.1+ for checkin to the 1.0 branch for the Mozilla1.0.1
milestone.  Please get drivers approval before checking in.
Keywords: adt1.0.0+ → adt1.0.1+
Comment on attachment 81921 [details] [diff] [review]
Add GB18030 to mail compose charset menu.

please check into the 1.0.1 branch ASAP. once landed remove the 
mozilla1.0.1+ keyword and add the fixed1.0.1 keyword
Attachment #81921 - Flags: approval+
checked in to the branch
Keywords: fixed1.0.1
Blocks: 146292
No longer blocks: 141008
Keywords: mozilla1.0.1+
Verified as fixed with the latest branch build.
Keywords: fixed1.0.1 → verified1.0.1
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: