1365079 - onClick fontcolor change of 'Legacy' label is not readable

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P5)

Description

[krupa raj [:krupa--use this to needinfo]]

55.0a1 (2017-05-10) (64-bit)

steps to reproduce:
0. Make sure to have at least one XUL add-on installed
1. Go to about:addons
2. Notice that the XUL add-on has the "Legacy" label.
4. Click on the label and see the font change color

expected behavior:
Font is always readable

actual behavior:
onClick font color changes to orange with yellow highlight which makes it not easy on the eyes.

screenshot:
Notice the label for the first label- 
https://www.dropbox.com/s/qgnud2kv2wefs3j/Screenshot%202017-05-15%2014.50.35.png?dl=0

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1365079 - Make legacy badge in about:addons more legible

Review commit: https://reviewboard.mozilla.org/r/145510/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145510/

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: legacy-transitions.mov.gif

The flip from "black" to white text was a little jarring without the transition so I added one. Colours and timing lifted from the photon visual design document.

Comment 3

[Robert Helmer [:rhelmer]]

Comment on attachment 8874055 [details]
Bug 1365079 - Make legacy badge in about:addons more legible

https://reviewboard.mozilla.org/r/145510/#review150278

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25b6519f489d
Make legacy badge in about:addons more legible r=rhelmer

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/25b6519f489d

Comment 6

[Vasilica Tamas, QA [:vtamas]]

Attachment: 2017-06-12_1137.png

Confirm that the “Legacy” label is readable when clicked on Firefox 55.0a1 (2017-06-11) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.1.
See attached screenshot.