Closed
Bug 1365124
Opened 8 years ago
Closed 8 years ago
Remove trivial GeckoInterface methods
Categories
(GeckoView :: General, enhancement)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(2 files)
|
4.12 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
|
4.07 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
Remove GeckoInterface methods that are not used.
|
Assignee | |
Comment 1•8 years ago
|
||
Remove areTabsShown because it is never called through GeckoInterface.
r=me for trivial patch.
Attachment #8868167 -
Flags: review+
|
|
Assignee | |
Comment 2•8 years ago
|
||
invalidateOptionsMenu is no longer called through GeckoInterface, so we
can safely remove it. r=me for trivial patch.
Attachment #8868168 -
Flags: review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/804d217db167
1. Remove GeckoInterface.areTabsShown; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/2596e74ab2a1
2. Remove GeckoInterface.invalidateOptionsMenu; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/c19f8df0cc5d
3. Don't call getGeckoInterface() in enableSensor/disableSensor/loadPluginClass; r=me
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/804d217db167
https://hg.mozilla.org/mozilla-central/rev/2596e74ab2a1
https://hg.mozilla.org/mozilla-central/rev/c19f8df0cc5d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•6 years ago
|
Target Milestone: Firefox 55 → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•