Closed Bug 1365126 Opened 3 years ago Closed 2 years ago

Remove GeckoInterface.createShortcut

Categories

(GeckoView :: General, enhancement)

50 Branch
Unspecified
Android
enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

No description provided.
Move shortcut creation code in GeckoApp to GeckoApplication, and make
the methods static so that we can call them without a GeckoInterface
instance. This lets us remove GeckoInterface.createShortcut.
Attachment #8868170 - Flags: review?(droeh)
Comment on attachment 8868170 [details] [diff] [review]
Move shortcut creation to static methods in GeckoApplication (v1)

Review of attachment 8868170 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good with a couple of nits.

::: mobile/android/base/java/org/mozilla/gecko/GeckoApplication.java
@@ +445,5 @@
> +                  }
> +              });
> +    }
> +
> +    /* protected */ static void createShortcutWithIcon(final String aTitle, final String aURI,

Did you mean /* package */ here?

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/ActivityUtils.java
@@ +61,5 @@
>  
>      /**
>       * Finish this activity and launch the default home screen activity.
>       */
> +    public static void goToHomeScreen(Context activity) {

Rename activity to context.
Attachment #8868170 - Flags: review?(droeh) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f5485d306e1
Move shortcut creation to static methods in GeckoApplication; r=droeh
https://hg.mozilla.org/mozilla-central/rev/6f5485d306e1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 55 → mozilla55
You need to log in before you can comment on or make changes to this bug.