Closed Bug 1365127 Opened 2 years ago Closed 2 years ago

Remove GeckoInterface history accessors

Categories

(GeckoView :: General, enhancement)

50 Branch
Unspecified
Android
enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

No description provided.
Move checkUriVisited, markUriVisited, and setUriTitle from
GeckoApp/GeckoAppShell to GlobalHistory. Make them static and directly
accessible from native code, so that we can remove those methods from
GeckoInterface.
Attachment #8868171 - Flags: review?(droeh)
Comment on attachment 8868171 [details] [diff] [review]
Move history accessors from GeckoAppShell to GlobalHistory (v1)

Review of attachment 8868171 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8868171 - Flags: review?(droeh) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8df517d010d
Move history accessors from GeckoAppShell to GlobalHistory; r=droeh
https://hg.mozilla.org/mozilla-central/rev/d8df517d010d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 55 → mozilla55
You need to log in before you can comment on or make changes to this bug.