Closed
Bug 1365127
Opened 8 years ago
Closed 8 years ago
Remove GeckoInterface history accessors
Categories
(GeckoView :: General, enhancement)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(1 file)
|
26.49 KB,
patch
|
droeh
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
Move checkUriVisited, markUriVisited, and setUriTitle from
GeckoApp/GeckoAppShell to GlobalHistory. Make them static and directly
accessible from native code, so that we can remove those methods from
GeckoInterface.
Attachment #8868171 -
Flags: review?(droeh)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8868171 [details] [diff] [review]
Move history accessors from GeckoAppShell to GlobalHistory (v1)
Review of attachment 8868171 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #8868171 -
Flags: review?(droeh) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8df517d010d
Move history accessors from GeckoAppShell to GlobalHistory; r=droeh
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•6 years ago
|
Target Milestone: Firefox 55 → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•