1365136 - Crash in FindItem when getting new mail, or opening mail. Only with Mac Sierra OS X 10.12, and not with OS X 10.13. SDK issue?

Status: RESOLVED WONTFIX

(Core :: Widget: Cocoa, defect, P3)

Description

[Wayne Mery (:wsmwk)]

FindItem ranks #2 for Mac crashes (#26 overall) for Thunderbird 52.1.0.  

These crashes only happen with Sierra. And for all pratical purposes not before 52.0.1. 45.x crash rate is near zero.  (one of the earliest is bp-e9bb55f5-b819-4d15-925b-cb03c0170427)
Also, no corresponding signature in 45.x, based on correlating users whose crashes have email addresses.

Peter's crash bp-b1652bd6-6720-4479-a6b5-2a9a30170515.
0 	CarbonCore	FindItem(OpaqueCollection*, unsigned int, int, unsigned long*)	
1 	CarbonCore	RemoveCollectionItem	
2 	HIToolbox	TSMRemoveDocumentProperty_Internal	
3 	AppKit	-[NSTextInputContext dealloc]	
4 	libobjc.A.dylib	objc_object::sidetable_release(bool)	
5 	libobjc.A.dylib	_object_remove_assocations	
6 	libobjc.A.dylib	objc_destructInstance	
7 	libobjc.A.dylib	object_dispose	
8 	AppKit	-[NSResponder dealloc]	
9 	AppKit	-[NSView dealloc]	
10 	XUL	-[ChildView dealloc]	widget/cocoa/nsChildView.mm:3401
11 	libobjc.A.dylib	objc_object::sidetable_release(bool)	
12 	libobjc.A.dylib	(anonymous namespace)::AutoreleasePoolPage::pop(void*)	
13 	CoreFoundation	_CFAutoreleasePoolPop	
14 	Foundation	-[NSAutoreleasePool drain]	
15 	XUL	base::MessagePumpDefault::Run(base::MessagePump::Delegate*)	ipc/chromium/src/base/message_pump_default.cc:82
16 	XUL	MessageLoop::Run()	ipc/chromium/src/base/message_loop.cc:232
17 	XUL	base::Thread::ThreadMain()	ipc/chromium/src/base/thread.cc:180
18 	XUL	ThreadFunc	ipc/chromium/src/base/platform_thread_posix.cc:38
19 	libsystem_pthread.dylib	_pthread_body	
20 	libsystem_pthread.dylib	_pthread_start	
21 	libsystem_pthread.dylib	thread_start	
22 	XUL	XUL@0x7c1c3f	

Peter's other crashes
bp-605b97dc-0079-44b4-ba0a-b0cc80170515	2017-05-15 08:45:59 	FindItem 
bp-bdc2dd0c-3d83-4388-b4b5-b336b0170512	2017-05-12 08:23:13 	FindItem 
bp-460439fc-80a2-4703-9114-ea0070170510	2017-05-10 07:00:25 	__CFBasicHashDeallocate  
bp-8bed7951-8325-478f-bfae-b315b0170504	2017-05-04 11:31:06 	FindItem

Comment 1

[Nomis101]

Are there any steps to reproduce? I don't get my TB 52.1.0/1 on Sierra to crash.

Comment 2

[Wayne Mery (:wsmwk)]

(In reply to Nomis101 from comment #1)
> Are there any steps to reproduce? I don't get my TB 52.1.0/1 on Sierra to crash.

Not so far - one of the disadvantages of not being a high volume crash.  

Earliest crashes I find are 53.0b2 like bp-cd56b655-3f94-4e2d-80d4-eecd40170505. No nightly crashes. No crashes reported for 53.0b1 or 52.0b*. Comments indicate this happens when getting new mail or opening mail. 

I am attempting to determine whether all reports are pop accounts.

Comment 3

[Makoto Kato [:m_kato]]

All crashes are via [NSTextView dealloc] or [ChildView dealloc].  Then, this crashes when [NSTextInputContext dealloc] releases internal objects.

bp-a75adcd8-c0b4-47e7-956d-ba78b0170515 is Firefox issue.  So moving to Core - Widget: Cocoa.

Comment 4

[Peter Peltonen]

These crashes do not happen that often: yesterday I had TB open and in use for all, day and the first crash of that day happened in the evening, here is the report:
https://crash-stats.mozilla.com/report/index/746f55eb-8545-4806-93c5-c32b90170517

I think I had just sent an email when it happened, it was like "send an email, switch to another workspace to do something and notice that TB had crashed". I try to pay attention more next time it crashes.

I am using no POP accounts: I have several IMAP accounts configured (143/STARTTLS).

I am using 52.1.1 for Mac. If you would like me to try out some other version, please let me know where I can download it.

Comment 5

[Wayne Mery (:wsmwk)]

#24 crash for 52.1.1

Comment 6

[Wayne Mery (:wsmwk)]

(In reply to Nomis101 from comment #1)
> Are there any steps to reproduce? I don't get my TB 52.1.0/1 on Sierra to crash.

User comments vary. But the most common comment is "deleting message". Next most common is "reading email".
Example of the former is bp-e8dd2da5-0d53-4d71-9960-e83e40170623 from a user who has crashed 66 times in one month.

What do you think we need to resolve this?

Comment 7

[Makoto Kato [:m_kato]]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #6)
> (In reply to Nomis101 from comment #1)
> > Are there any steps to reproduce? I don't get my TB 52.1.0/1 on Sierra to crash.
> 
> User comments vary. But the most common comment is "deleting message". Next
> most common is "reading email".
> Example of the former is bp-e8dd2da5-0d53-4d71-9960-e83e40170623 from a user
> who has crashed 66 times in one month.
> 
> What do you think we need to resolve this?

This seems to occurs that any window (child view) is closed / disappears.  And 100% (except to bp-e6f5ac9b-7e62-4620-849b-28fe20170627.  It is another issue) is on macOS 10.12.  I think that this may be OS bug, but I don't know why this crash occur.

Comment 8

[Nomis101]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #6)
> (In reply to Nomis101 from comment #1)
> > Are there any steps to reproduce? I don't get my TB 52.1.0/1 on Sierra to crash.
> 
> User comments vary. But the most common comment is "deleting message". Next
> most common is "reading email".
> Example of the former is bp-e8dd2da5-0d53-4d71-9960-e83e40170623 from a user
> who has crashed 66 times in one month.
> 
> What do you think we need to resolve this?

Sadly, I don't know. Could this happen only on 10.12, because we are building with an older SDK?

Comment 9

[Wayne Mery (:wsmwk)]

Crashes dropped to near zero for beta 55 and 56. So something happened between 54 and 55.
- https://crash-stats.mozilla.com/signature/?product=Thunderbird&release_channel=beta&_sort=-date&signature=FindItem&date=%3E%3D2017-02-28T21%3A36%3A25.000Z&date=%3C2017-08-28T21%3A36%3A25.000Z#graphs
- https://crash-stats.mozilla.com/signature/?product=Thunderbird&release_channel=beta&signature=FindItem&date=%3E%3D2017-05-28T21%3A40%3A33.000Z&date=%3C2017-08-28T21%3A40%3A33.000Z#graphs

So the question is - what got fixed?  (assuming mac users are not somehow stuck on 54 beta)

10.12.6 16G29 is the latest sierra build from late July, and afaict it had no impact on 52.3.0 where crashing is still going strong

https://crash-stats.mozilla.com/search/?signature=~FindItem&product=Thunderbird&date=%3E%3D2017-08-21T21%3A59%3A26.000Z&date=%3C2017-08-28T21%3A59%3A26.000Z&_sort=-date&_facets=signature&_facets=version&_facets=platform_version&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=platform_pretty_version#facet-platform_version

https://crash-stats.mozilla.com/search/?signature=~FindItem&platform_version=%3D10.12.6%2016G29&product=Thunderbird&date=%3E%3D2017-08-21T21%3A59%3A26.000Z&date=%3C2017-08-28T21%3A59%3A26.000Z&_sort=-date&_facets=signature&_facets=version&_facets=platform_version&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=platform_pretty_version#facet-version

Comment 10

[Nomis101]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #9) 
> So the question is - what got fixed?  (assuming mac users are not somehow
> stuck on 54 beta)
> 
That is a good question. I would expect it was any Core change. But which of those, I don't know. Is the any change log of what was changed between 54 and beta 55?

Comment 11

[Wayne Mery (:wsmwk)]

Noteworthy, crash-stats has zero crashes for High Sierra, and overall 9% of Mac crashes are High Sierra which is a significant percentage and no doubt growing.  So crash seems specific to 10.12, and crash is gone in 10.13.  Still, a very high crash rate for Macs overall, ranks #14 for TB52.4.0

Comment 12

[Wayne Mery (:wsmwk)]

#1 Mac crash, And still in 57.0b1 bp-312c77ac-30e5-4694-990c-4bf6f0171110 OS X 10.12 (garrideb) " Read msg in vertically-expanded mode, reduced to normal size, clicked on get msgs, crash."

I did more snooping around and find no 10.13.x crashes of comparble crash volume - other than shutdown crash.


(In reply to Makoto Kato [:m_kato] from comment #7)
> (In reply to Wayne Mery (:wsmwk, NI for questions) from comment #6)
> > (In reply to Nomis101 from comment #1)
> > > Are there any steps to reproduce? I don't get my TB 52.1.0/1 on Sierra to crash.
> > 
> > User comments vary. But the most common comment is "deleting message". Next
> > most common is "reading email".
> > Example of the former is bp-e8dd2da5-0d53-4d71-9960-e83e40170623 from a user
> > who has crashed 66 times in one month.
> > 
> > What do you think we need to resolve this?
> 
> This seems to occurs that any window (child view) is closed / disappears. 
> And 100% (except to bp-e6f5ac9b-7e62-4620-849b-28fe20170627.  It is another
> issue) is on macOS 10.12.  I think that this may be OS bug, but I don't know
> why this crash occur.

Is bp-066f15a8-9985-43ef-a066-cb7570171007 @ libsystem_kernel.dylib@0x1bfce with nsChildView::DoRemoteComposition on the stack related?

Comment 13

[Makoto Kato [:m_kato]]

(In reply to Wayne Mery (:wsmwk) from comment #12)

> > This seems to occurs that any window (child view) is closed / disappears. 
> > And 100% (except to bp-e6f5ac9b-7e62-4620-849b-28fe20170627.  It is another
> > issue) is on macOS 10.12.  I think that this may be OS bug, but I don't know
> > why this crash occur.
> 
> Is bp-066f15a8-9985-43ef-a066-cb7570171007 @ libsystem_kernel.dylib@0x1bfce
> with nsChildView::DoRemoteComposition on the stack related?

This crash id is GPU related, so it isn't same issue.

Comment 14

[Wayne Mery (:wsmwk)]

https://crash-stats.mozilla.com/signature/?product=Thunderbird&signature=FindItem&date=%3E%3D2017-12-23T16%3A00%3A56.000Z&date=%3C2018-01-23T16%3A00%3A56.000Z still indicates this is gone for OS X 10.13

Comment 15

[Wayne Mery (:wsmwk)]

(In reply to Wayne Mery (:wsmwk) from comment #14)
> https://crash-stats.mozilla.com/signature/?product=Thunderbird&signature=FindItem&date=%3E%3D2017-12-23T16%3A00%3A56.000Z&date=%3C2018-01-23T16%3A00%3A56.000Z still indicates this is gone for OS X 10.13

Confirmed also in https://support.mozilla.org/en-US/questions/1198966

Comment 17

[Wayne Mery (:wsmwk)]

No crashes for Thunderbird users on 10.13. So should we close this?

Comment 18

[Wayne Mery (:wsmwk)]

About 40% reduction in crashes since mid-January

Comment 19

[Markus Stange [:mstange]]

(In reply to Wayne Mery (:wsmwk) from comment #17)
> No crashes for Thunderbird users on 10.13. So should we close this?

I guess so? Realistically we're probably not going to spend time on it.