1365218 - Add support for drawing decorated windows on GTK 3.20.

Status: RESOLVED WONTFIX

(Core :: Widget: Gtk, enhancement, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Follow up from Bug 1283299 Part 2: Add support for drawing decorated windows on GTK 3.20.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1365218 - Add support for drawing decorated windows on GTK 3.20,

Review commit: https://reviewboard.mozilla.org/r/140058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140058/

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8868452 [details]
Bug 1365218 - Add support for drawing decorated windows on GTK 3.20,

https://reviewboard.mozilla.org/r/140058/#review143378

::: widget/gtk/gtk3drawing.cpp:260
(Diff revision 1)
>      ReleaseStyleContext(style);
>      return MOZ_GTK_SUCCESS;
>  }
>  
> +void
> +moz_gtk_get_window_border(gint* top, gint* right, gint* bottom, gint* left)

I used a bit different approach here - it's close to get_shadow_width().

Comment 3

[Karl Tomlinson (:karlt)]

Comment on attachment 8868452 [details]
Bug 1365218 - Add support for drawing decorated windows on GTK 3.20,

https://reviewboard.mozilla.org/r/140058/#review171474

Michael has shown an interest in this work and may be able to review before I
can.

Michael, much of the remaining work in reviewing here involves checking that
this mimics what is done in the corresponding GTK code.  See the first version
of this patch in bug 1283299 and its review.  Please also consider the two
options identified in https://bugzilla.mozilla.org/show_bug.cgi?id=1283299#c22

The patch is on top of that for bug 1365218, and so may depend on that.

Comment 4

[Karl Tomlinson (:karlt)]

Comment on attachment 8868452 [details]
Bug 1365218 - Add support for drawing decorated windows on GTK 3.20,

https://reviewboard.mozilla.org/r/140058/#review171474

I mean bug 1364843.

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8868452 [details]
Bug 1365218 - Add support for drawing decorated windows on GTK 3.20,

I don't think that I am an appropriate reviewer for these patches. I don't have sufficient experience with gtk to perform the review.

I took a look this weekend to see if I would be able to help, but I don't think I'll be able to catch errors in the usage of the gtk APIs as I have never used them before.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8868452 [details]
Bug 1365218 - Add support for drawing decorated windows on GTK 3.20,

I updated the complete patch for latest trunk and working on that as a whole project. No need to review this particular patch right now - I'll attach another (and I hope fixed) one.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Not needed as we leave Gtk+ to render the decorations. See Bug 1399611 comment 11.