Add support for drawing decorated windows on GTK 3.20.

RESOLVED WONTFIX

Status

()

enhancement
P3
normal
RESOLVED WONTFIX
2 years ago
2 years ago

People

(Reporter: stransky, Assigned: stransky)

Tracking

(Blocks 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: tpi:+)

Attachments

(1 attachment)

Follow up from Bug 1283299 Part 2: Add support for drawing decorated windows on GTK 3.20.
Comment hidden (mozreview-request)
Assignee

Comment 2

2 years ago
mozreview-review
Comment on attachment 8868452 [details]
Bug 1365218 - Add support for drawing decorated windows on GTK 3.20,

https://reviewboard.mozilla.org/r/140058/#review143378

::: widget/gtk/gtk3drawing.cpp:260
(Diff revision 1)
>      ReleaseStyleContext(style);
>      return MOZ_GTK_SUCCESS;
>  }
>  
> +void
> +moz_gtk_get_window_border(gint* top, gint* right, gint* bottom, gint* left)

I used a bit different approach here - it's close to get_shadow_width().

Updated

2 years ago
Whiteboard: tpi:+
Assignee: nobody → stransky
Status: NEW → ASSIGNED

Comment 3

2 years ago
mozreview-review
Comment on attachment 8868452 [details]
Bug 1365218 - Add support for drawing decorated windows on GTK 3.20,

https://reviewboard.mozilla.org/r/140058/#review171474

Michael has shown an interest in this work and may be able to review before I
can.

Michael, much of the remaining work in reviewing here involves checking that
this mimics what is done in the corresponding GTK code.  See the first version
of this patch in bug 1283299 and its review.  Please also consider the two
options identified in https://bugzilla.mozilla.org/show_bug.cgi?id=1283299#c22

The patch is on top of that for bug 1365218, and so may depend on that.

Comment 4

2 years ago
mozreview-review-reply
Comment on attachment 8868452 [details]
Bug 1365218 - Add support for drawing decorated windows on GTK 3.20,

https://reviewboard.mozilla.org/r/140058/#review171474

I mean bug 1364843.
Attachment #8868452 - Flags: review?(karlt) → review?(michael)
Comment on attachment 8868452 [details]
Bug 1365218 - Add support for drawing decorated windows on GTK 3.20,

I don't think that I am an appropriate reviewer for these patches. I don't have sufficient experience with gtk to perform the review.

I took a look this weekend to see if I would be able to help, but I don't think I'll be able to catch errors in the usage of the gtk APIs as I have never used them before.
Attachment #8868452 - Flags: review?(michael) → review?(karlt)
Assignee

Comment 6

2 years ago
Comment on attachment 8868452 [details]
Bug 1365218 - Add support for drawing decorated windows on GTK 3.20,

I updated the complete patch for latest trunk and working on that as a whole project. No need to review this particular patch right now - I'll attach another (and I hope fixed) one.
Attachment #8868452 - Flags: review?(karlt)
Assignee

Comment 7

2 years ago
Not needed as we leave Gtk+ to render the decorations. See Bug 1399611 comment 11.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.