1365233 - Browser debugger content (ie file contents) pane goes blank and stays blank when switching to other tabs before stopping on breakpoint

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[:Gijs (he/him)]

STR:

1. open browser toolbox
2. set breakpoint in SearchSuggestionsController.jsm first line of first method hit when searching for "fetch("
3. switch to network tab
4. switch to the browser, select the search bar and type something
5. typing will stop working because the debugger kicks in - switch to the toolbox


ER:
switch to debugger tab, display 'paused on breakpoint', show file + line where we're stopped

AR:
switch to debugger tab, display 'paused on breakpoint', but file pane is empty

Switching to other files in the file pane doesn't work either. It looks like the component showing file content is just busted.

Comment 1

[Julian Descottes [:jdescottes]]

Might be fixed by a patch I currently attached to Bug 1365059 (https://bug1365059.bmoattachments.org/attachment.cgi?id=8868040). STRs I fixed are:
1. hit a breakpoint in debugger
2. switch to another tool
3. switch back to debugger

ER: Debugger should display the file content 
AR: Debugger shows an empty tab, new tabs can't be created 

Note that there is still an issue even with this fix, the scroll is not correctly restored in the opened tab.

I discussed with :jlast yesterday and I think he wanted to release a new debugger version soon (ie today) which is why for now I attached my patch to the other bug. However if it doesn't move fast enough I'll land it separately (once I fixed the try failures my patch seems to introduce of course).

Comment 2

[Julian Descottes [:jdescottes]]

I opened a dedicated bug to land the patch mentioned above. Trees are closed so it's in checkin needed.
Blocking this one on it.

Comment 3

[Julian Descottes [:jdescottes]]

Gijs, can you check if the issue is fixed for you on Nightly?

Comment 4

[:Gijs (he/him)]

(In reply to Julian Descottes [:jdescottes] from comment #3)
> Gijs, can you check if the issue is fixed for you on Nightly?

Yep, looks fixed to me, though now I noticed a separate issue with the 'find' implementation... will file a separate bug. :-)