1365269 - tools/profiler/public/GeckoProfiler.h:31:10: fatal error: PseudoStack.h: No such file or directory

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Jan Beich]

Gecko Profiler is not implemented on many Tier3 platforms (e.g. Linux on non-x86, iOS, Darwin/X11, BSDs, Solaris) but PseudoStack.h is not exposed otherwise.

In file included from objdir/dom/presentation/Unified_cpp_dom_presentation0.cpp:2:
In file included from dom/presentation/AvailabilityCollection.cpp:10:
In file included from dom/presentation/PresentationAvailability.h:10:
In file included from objdir/dist/include/mozilla/DOMEventTargetHelper.h:19:
In file included from objdir/dist/include/mozilla/EventListenerManager.h:11:
In file included from objdir/dist/include/mozilla/dom/EventListenerBinding.h:12:
In file included from objdir/dist/include/mozilla/dom/ToJSValue.h:12:
In file included from objdir/dist/include/mozilla/dom/BindingUtils.h:35:
In file included from dom/base/nsJSUtils.h:19:
objdir/dist/include/GeckoProfiler.h:31:10: fatal error: 'PseudoStack.h' file not found
#include "PseudoStack.h"
         ^~~~~~~~~~~~~~~
1 error generated.

http://searchfox.org/mozilla-central/rev/ae24a3c83d22/tools/profiler/moz.build#15

Comment 1

[Jan Beich]

Attachment: Bug 1365269 - Unbreak non-GeckoProfiler platforms after bug 1362894.

Review commit: https://reviewboard.mozilla.org/r/139760/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139760/

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8868150 [details]
Bug 1365269 - Unbreak non-GeckoProfiler platforms after bug 1362894.

https://reviewboard.mozilla.org/r/139760/#review143228

Surely you need to remove the |#include "PseudoStack.h"| on line 31 as well?

Comment 3

[Jan Beich]

Comment on attachment 8868150 [details]
Bug 1365269 - Unbreak non-GeckoProfiler platforms after bug 1362894.

https://reviewboard.mozilla.org/r/139760/#review143228

Doh, I suspect git was too optimistic about rebase. ;)

Comment 4

[Jan Beich]

Comment on attachment 8868150 [details]
Bug 1365269 - Unbreak non-GeckoProfiler platforms after bug 1362894.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/139760/diff/1-2/

Comment 5

[Nicholas Nethercote [inactive]]

Comment on attachment 8868150 [details]
Bug 1365269 - Unbreak non-GeckoProfiler platforms after bug 1362894.

https://reviewboard.mozilla.org/r/139760/#review143278

Much better! Sorry for the bustage, and thank you for the fix.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f14fb118695e
Unbreak non-GeckoProfiler platforms after bug 1362894. r=njn

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f14fb118695e