Closed Bug 1365342 Opened 3 years ago Closed 3 years ago

Extract the preview comment functionality and make it a reusable template

Categories

(bugzilla.mozilla.org :: Bug Creation/Editing, defect, P1)

Production
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: seban, Assigned: seban, Mentored)

References

Details

Attachments

(1 file, 1 obsolete file)

PR
44 bytes, text/x-github-pull-request
dylan
: review+
Details | Review
Load all of bug_modal.js, bug_modal.css, and bug_modal/new_comment.html.tmpl to get the preview comment functionality into a page.

Further, bug_modal/new_comment.html.tmpl requires a bug object to be passed to it.

bug_modal/new_comment.html.tmpl should be generalized to work either with or without a bug object passed in, and bug_modal.js’s bugzilla_ajax should be moved to js/util.js, and the code parts of previewing comments from bug_modal.js to js/comments.js
Once this is completed, the next step would be to replace library (jQuery/YUI) wrappers for XMLHTTPRequest with Fetch and the Fetch polyfill for older browsers.
Acknowledged.
Attached file PR
Woops, forgot this part.
Attachment #8876783 - Flags: review+
Attachment #8876784 - Flags: review?(dylan)
Attachment #8876784 - Attachment is obsolete: true
Attachment #8876784 - Flags: review?(dylan)
Can this be resolved?
Flags: needinfo?(dylan)
To git@github.com:mozilla-bteam/bmo.git
   b1abfe7ca..9243cbb3b  HEAD -> HEAD
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Flags: needinfo?(dylan)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.