1365345 - Modal Bug Entry Prototype

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Bug Creation/Editing, enhancement)

Description

[Sebastin Santy [:seban]]

This should feature the null, status, and comment widgets/modules.

Comment 1

[Sebastin Santy [:seban]]

Attachment: PR

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8881143 [details] [review]
PR

I had to back this out due to test failures. 
I neglected to run "prove t", but you should do that before submitting PRs for review.

The error found in particular can be dangerous (and I'm ashamed that I read over the code and didn't notice -- but this is why we have a test):

not ok 3397 - new_bug.cgi incorrectly passes a CGI argument to a hash --ERROR
# short_desc   => $cgi->param('short_desc'), on line 50
# product      => $cgi->param('product'), on line 51
# component    => $cgi->param('component'), on line 52
# comment      => $cgi->param('comment'), on line 59

When calling $cgi->param() it is important to force scalar context, by prefixing the call with scalar or assigning to a scalar ($) variable.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Attachment: PR

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8883642 [details] [review]
PR

t/009bugwords.t .. 599/730
#   Failed test 'template/en/default/bug/new_bug.html.tmpl contains invalid bare words (e.g. 'bug') --WARNING'
#
#   at t/009bugwords.t line 68.
#
# Looks like you failed 1 test of 730.