Avoid function name atomizing to improve performance of _FinishBoundFunctionInit

RESOLVED FIXED in Firefox 55

Status

()

Core
JavaScript Engine
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: André Bargull, Assigned: André Bargull)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a month ago
By popular demand (bug 1365361), improve the performance of _FinishBoundFunctionInit by delaying function name atomizing.
(Assignee)

Comment 1

a month ago
Created attachment 8868264 [details] [diff] [review]
bug1365387.patch

Improves this µ-benchmark from 180ms to 110ms for me:

function fn(){}
var t = Date.now();
for (var i = 0; i < 1000000; ++i) fn.bind();
print( Date.now() - t );
Attachment #8868264 - Flags: review?(till)
Blocks: 1365361
Comment on attachment 8868264 [details] [diff] [review]
bug1365387.patch

Review of attachment 8868264 [details] [diff] [review]:
-----------------------------------------------------------------

That's a surprisingly large win, thank you!
Attachment #8868264 - Flags: review?(till) → review+
(Assignee)

Comment 3

a month ago
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8e3a254662fa9f271e8524ad9020d70e78aadc0
Keywords: checkin-needed

Comment 4

a month ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/228a1e9bcc4b
Optimize FinishBoundFunctionInit by delaying atomizing the function name. r=till
Keywords: checkin-needed

Comment 5

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/228a1e9bcc4b
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.