1365387 - Avoid function name atomizing to improve performance of _FinishBoundFunctionInit

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[André Bargull [:anba]]

By popular demand (bug 1365361), improve the performance of _FinishBoundFunctionInit by delaying function name atomizing.

Comment 1

[André Bargull [:anba]]

Attachment: bug1365387.patch

Improves this µ-benchmark from 180ms to 110ms for me:

function fn(){}
var t = Date.now();
for (var i = 0; i < 1000000; ++i) fn.bind();
print( Date.now() - t );

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8868264 [details] [diff] [review]
bug1365387.patch

Review of attachment 8868264 [details] [diff] [review]:
-----------------------------------------------------------------

That's a surprisingly large win, thank you!

Comment 3

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8e3a254662fa9f271e8524ad9020d70e78aadc0

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/228a1e9bcc4b
Optimize FinishBoundFunctionInit by delaying atomizing the function name. r=till

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/228a1e9bcc4b