1365399 - Option element constructor is not per spec

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Domenic Denicola]

In particular it appears to handle defaultSelected incorrectly and sets dirtiness incorrectly. See test at http://w3c-test.org/html/semantics/forms/the-option-element/option-element-constructor.html and spec at https://html.spec.whatwg.org/#dom-option

This is probably related to (a dupe of?) https://bugzilla.mozilla.org/show_bug.cgi?id=1300282

Comment 1

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Some of the work has been done in Bug 1365598.
This bug fixes this statement in the spec (https://html.spec.whatwg.org/#dom-option):
  If selected is true, then set option's selectedness to true; otherwise set its
  selectedness to false (even if defaultSelected is true).
And also reset the dirtiness.

This patch also reverts the changes in Bug 927796 and 942648, which was added
because IsSelected() returned inaccurately (called from SelectSomething()).
Verified that the tests added in Bug 927796 and 942648 do pass.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8871643 [details] [diff] [review]
patch, v1.

So mSelectedChanged is used only by HTMLOptionElement::SetSelectedInternal now and checked in HTMLOptionElement::BeforeSetAttr

Comment 3

[Jessica Jong [:jessica] (inactive)]

(In reply to Olli Pettay [:smaug] from comment #2)
> Comment on attachment 8871643 [details] [diff] [review]
> patch, v1.
> 
> So mSelectedChanged is used only by HTMLOptionElement::SetSelectedInternal
> now and checked in HTMLOptionElement::BeforeSetAttr

Exactly, and cleared (set to false) in Option constructor (added in this patch) and in HTMLSelectElement::Reset.

Comment 4

[Jessica Jong [:jessica] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b8442490f0e5ba16074b7327dc1af17a99634b3&group_state=expanded

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/933ff638ea34
Handle selectedness and dirtiness correctly in Option constructor. r=smaug

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/933ff638ea34