Remove GeckoInterface.getDefaultChromeURI

RESOLVED FIXED in Firefox 55

Status

RESOLVED FIXED
2 years ago
2 months ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

50 Branch
mozilla55
All
Android
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 8868704 [details] [diff] [review]
Remove GeckoInterface.getDefaultChromeURI (v1)

Add getChromeUri/setChromeUri APIs to GeckoView, to allow each
GeckoView's chrome URI to be set individually. This lets us remove
GeckoInterface.getDefaultChromeURI. This patch also changes the default
URI value to the GeckoView default, and let Fennec specify its chrome
URI (browser.xul) inside GeckoApp.
Attachment #8868704 - Flags: review?(droeh)
Comment on attachment 8868704 [details] [diff] [review]
Remove GeckoInterface.getDefaultChromeURI (v1)

Review of attachment 8868704 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8868704 - Flags: review?(droeh) → review+

Comment 3

2 years ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1dce43934107
Remove GeckoInterface.getDefaultChromeURI; r=droeh

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1dce43934107
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Updated

2 months ago
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 55 → mozilla55
You need to log in before you can comment on or make changes to this bug.