Closed Bug 1365485 Opened 3 years ago Closed 2 years ago

Remove GeckoInterface.getDefaultChromeURI

Categories

(GeckoView :: General, enhancement)

50 Branch
All
Android
enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

No description provided.
Add getChromeUri/setChromeUri APIs to GeckoView, to allow each
GeckoView's chrome URI to be set individually. This lets us remove
GeckoInterface.getDefaultChromeURI. This patch also changes the default
URI value to the GeckoView default, and let Fennec specify its chrome
URI (browser.xul) inside GeckoApp.
Attachment #8868704 - Flags: review?(droeh)
Comment on attachment 8868704 [details] [diff] [review]
Remove GeckoInterface.getDefaultChromeURI (v1)

Review of attachment 8868704 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8868704 - Flags: review?(droeh) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1dce43934107
Remove GeckoInterface.getDefaultChromeURI; r=droeh
https://hg.mozilla.org/mozilla-central/rev/1dce43934107
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 55 → mozilla55
You need to log in before you can comment on or make changes to this bug.