Closed Bug 1365520 Opened 4 years ago Closed 4 years ago

Remove MDSM::mSentLoadedMetadataEvent and MDSM::EnqueueLoadedMetadataEvent()

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(2 files)

The current call flow ensures decoding metadata only happens at most once and therefore EnqueueLoadedMetadataEvent() will only be called at most once. We don't need the mSentLoadedMetadataEvent flag.
Assignee: nobody → jwwang
Priority: -- → P3
Comment on attachment 8868823 [details]
Bug 1365520. P1 - remove MDSM::mSentLoadedMetadataEvent and MDSM::EnqueueLoadedMetadataEvent().

https://reviewboard.mozilla.org/r/140408/#review143752
Attachment #8868823 - Flags: review?(kaku) → review+
Comment on attachment 8868824 [details]
Bug 1365520. P2 - remove mMetadataTags for we can pass |aMetadata->mTags| without storing it.

https://reviewboard.mozilla.org/r/140410/#review143754
Attachment #8868824 - Flags: review?(kaku) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e859332938c
P1 - remove MDSM::mSentLoadedMetadataEvent and MDSM::EnqueueLoadedMetadataEvent(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/bc73a476b270
P2 - remove mMetadataTags for we can pass |aMetadata->mTags| without storing it. r=kaku
https://hg.mozilla.org/mozilla-central/rev/3e859332938c
https://hg.mozilla.org/mozilla-central/rev/bc73a476b270
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.