1365520 - Remove MDSM::mSentLoadedMetadataEvent and MDSM::EnqueueLoadedMetadataEvent()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

The current call flow ensures decoding metadata only happens at most once and therefore EnqueueLoadedMetadataEvent() will only be called at most once. We don't need the mSentLoadedMetadataEvent flag.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1365520. P1 - remove MDSM::mSentLoadedMetadataEvent and MDSM::EnqueueLoadedMetadataEvent().

The current call flow ensures decoding metadata only happens at most once
and therefore EnqueueLoadedMetadataEvent() will only be called at most once.
We don't need the mSentLoadedMetadataEvent flag.

Review commit: https://reviewboard.mozilla.org/r/140408/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140408/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1365520. P2 - remove mMetadataTags for we can pass |aMetadata->mTags| without storing it.

Review commit: https://reviewboard.mozilla.org/r/140410/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140410/

Comment 3

[Tzuhao Kuo [:kaku]]

Comment on attachment 8868823 [details]
Bug 1365520. P1 - remove MDSM::mSentLoadedMetadataEvent and MDSM::EnqueueLoadedMetadataEvent().

https://reviewboard.mozilla.org/r/140408/#review143752

Comment 4

[Tzuhao Kuo [:kaku]]

Comment on attachment 8868824 [details]
Bug 1365520. P2 - remove mMetadataTags for we can pass |aMetadata->mTags| without storing it.

https://reviewboard.mozilla.org/r/140410/#review143754

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e859332938c
P1 - remove MDSM::mSentLoadedMetadataEvent and MDSM::EnqueueLoadedMetadataEvent(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/bc73a476b270
P2 - remove mMetadataTags for we can pass |aMetadata->mTags| without storing it. r=kaku

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3e859332938c
https://hg.mozilla.org/mozilla-central/rev/bc73a476b270