Remove MDSM::mSentLoadedMetadataEvent and MDSM::EnqueueLoadedMetadataEvent()

RESOLVED FIXED in Firefox 55

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
The current call flow ensures decoding metadata only happens at most once and therefore EnqueueLoadedMetadataEvent() will only be called at most once. We don't need the mSentLoadedMetadataEvent flag.
(Assignee)

Updated

2 years ago
Assignee: nobody → jwwang
Priority: -- → P3
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8868823 [details]
Bug 1365520. P1 - remove MDSM::mSentLoadedMetadataEvent and MDSM::EnqueueLoadedMetadataEvent().

https://reviewboard.mozilla.org/r/140408/#review143752
Attachment #8868823 - Flags: review?(kaku) → review+

Comment 4

2 years ago
mozreview-review
Comment on attachment 8868824 [details]
Bug 1365520. P2 - remove mMetadataTags for we can pass |aMetadata->mTags| without storing it.

https://reviewboard.mozilla.org/r/140410/#review143754
Attachment #8868824 - Flags: review?(kaku) → review+
(Assignee)

Comment 5

2 years ago
Thanks!

Comment 6

2 years ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e859332938c
P1 - remove MDSM::mSentLoadedMetadataEvent and MDSM::EnqueueLoadedMetadataEvent(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/bc73a476b270
P2 - remove mMetadataTags for we can pass |aMetadata->mTags| without storing it. r=kaku

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3e859332938c
https://hg.mozilla.org/mozilla-central/rev/bc73a476b270
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.