1365528 - `text-overflow: ellipsis` renders garbled [was: does not apply] ellipsis with any "filter" style

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P1)

Description

[yair even or]

Attachment: jsbin.bomijapobe.1.html

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161208153507

Steps to reproduce:

demo - http://jsbin.com/bomijapobe/edit?html,css,output

Create any element with a long enough text inside it.

style the element with basic standard ellipsis CSS:

{ 
    text-overflow: ellipsis; 
    overflow: hidden; 
    white-space: nowrap;
    width: 50%; 
}

Give the element a filter of any kind

{ filter: grayscale(1); }





Actual results:

ellipsis disappears when filter is applied.


Expected results:

filter should have been applied and ellipsis remaining

Comment 1

[yair even or]

Even if you apply the filter to an ancestor element, bug persists:

body{ filter: grayscale(1); }

Comment 2

[Mats Palmgren (inactive)]

Fwiw, the attached testcase works fine for me in Firefox 53 and Nightly 55 on Linux.

Comment 3

[Jonathan Kew [:jfkthame]]

I just tried the testcase here in Nightly 58 on macOS, and the text-overflow ellipsis does appear -- but its rendering is pretty badly garbled by the filter, apparently. Which seems more like a Graphics than Layout:Text issue at this point... Markus, ISTR you know something about filters, can you take a look?

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Screenshot of the testcase showing garbled ellipsis when filter is applied

Here's what it looks like for me. Note that disabling the filter leaves the ellipsis looking just fine; and an ellipsis character within the actual text (rather than added by text-overflow) also looks fine (even with the filter).

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1365528 - Respect mDisableSubpixelAA on nsDisplayTextOverflowMarker items.

Review commit: https://reviewboard.mozilla.org/r/191676/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191676/

Comment 6

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8920675 [details]
Bug 1365528 - Respect mDisableSubpixelAA on nsDisplayTextOverflowMarker items.

https://reviewboard.mozilla.org/r/191676/#review196900

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1db434bfcf1
Respect mDisableSubpixelAA on nsDisplayTextOverflowMarker items. r=mattwoodrow

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b1db434bfcf1