1365566 - Use PR_GetSystemInfo to get OS version instead of using system info

Status: RESOLVED FIXED

(Core :: Networking, enhancement)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

As bug 1363421 described, constructing system info might take more time on certain platform. Since nsHttpHandler only needs one information from system info, we can improve the performance by using NSPR API directly.

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: Bug 1365566 - use PR_GetSystemInfo to get OS version on Firefox desktop. .

Review commit: https://reviewboard.mozilla.org/r/140140/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140140/

Comment 2

[Dragana Damjanovic [:dragana]]

Comment on attachment 8868519 [details]
Bug 1365566 - use PR_GetSystemInfo to get OS version on Firefox desktop. .

https://reviewboard.mozilla.org/r/140140/#review143964

Thanks alot for fixing this!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d4c6f246ae6
use PR_GetSystemInfo to get OS version on Firefox desktop. r=dragana.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9d4c6f246ae6