1365590 - add patcher config for DevEdition

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement)

Description

[[e-mail] (:bhearsum)]

We'll need one to ship it as a release style build!

Comment 1

[Rail Aliiev [:rail]]

  * patcher config bumper should use stage_product to generate URLs to the candidates directory, see first attempt at https://gist.github.com/rail/98448b412f549bcea39235d236f8b420
  * add a new patcher config, the same gist
  * review/land https://hg.mozilla.org/projects/jamun/rev/f4081b4d96cf to enable the patch above

Comment 2

[Aki Sasaki (not active)]

I've landed these on https://hg.mozilla.org/users/raliiev_mozilla.com/tools . I think they'll work for a staging beta if we pre-populate the mars, though my understanding is very fuzzy here.

When we land for real (for 55.0b1 or whatever production pre-55.0b1 beta), this was our thinking:

#dawn
16:04 <nthomas> I’m trying to find what we used to have for a minimal skeleton in hg history
16:11 <nthomas> https://hg.mozilla.org/build/tools/rev/651f86737204 is the most recent, I think
16:11 <nthomas> still need a previous release in there
16:11 <aki> ok
16:13 <aki> looks like we have 2 previous atm
16:13 <nthomas> for jamun ?
16:13 <aki> in https://hg.mozilla.org/users/raliiev_mozilla.com/tools/file/a4633fd369f2/release/patcher-configs/mozDevedition-branch-patcher2.cfg ?
16:14 <nthomas> (btw, in 651f86737204 there is some now deprecated crud, eg <rc>, actions
16:14 <nthomas> hmm, so http://archive.mozilla.org/pub/devedition/candidates/ which doesn’t exist
16:14 <aki> with https://bugzilla.mozilla.org/show_bug.cgi?id=1365422 we can populate b6 and b7
16:15 <aki> with some complete mars
16:15 <aki> i think
16:16 <nthomas> I’m a bit confused again. There’s what we want for testing, and what we want for the first ‘for real’ devedition
16:17 <aki> sure
16:17 <aki> so your comments above were for the latter?
16:17 <nthomas> yeah, pretty much
16:17 <nthomas> doing the former is obviously valuable too
16:18 <aki> how do we deal with the "previous release" if it was only nightly-channel stuff? fake it?
16:18 <aki> for "for real" devedition
16:21 <nthomas> I’m not sure tbh, it depends a lot how funsize finds the previous release to generate those partials
16:21 <aki> ideally we get this done sooner so we can do a test run with 54.0bX
16:22 <nthomas> maybe we copy from firefox/nightly/ to devedition/candidates/last-nightly/ with appropriate path munging and renaming ?
16:22 <aki> sure
16:23 <nthomas> and then bung that into balrog, pretty sure that’s where funsize goes

Comment 3

[Rail Aliiev [:rail]]

It finally ran, but failed: https://archive.mozilla.org/pub/devedition/tinderbox-builds/jamun-noarch/release-jamun-devedition_updates-bm77-build1-build2.txt.gz

Comment 4

[Rail Aliiev [:rail]]

I pushed something in hope it fixes it: https://hg.mozilla.org/users/raliiev_mozilla.com/tools/rev/05c1f27d360e

Comment 5

[Rail Aliiev [:rail]]

Nope, https://archive.mozilla.org/pub/devedition/tinderbox-builds/jamun-noarch/release-jamun-devedition_updates-bm73-build1-build8.txt.gz

I think we have to use "firefox" as product in the command line and handle the "url" variable somehow...

Comment 6

[Rail Aliiev [:rail]]

Will test https://hg.mozilla.org/users/raliiev_mozilla.com/tools/rev/e4db13ad72f0 and https://hg.mozilla.org/projects/jamun/rev/e480b49a438842a78d770c9133fded0cac02f0aa with the following hack:

diff --git a/releasetasks/templates/desktop/updates.yml.tmpl b/releasetasks/templates/desktop/updates.yml.tmpl
index 5fa5a5f..9300dd7 100644
--- a/releasetasks/templates/desktop/updates.yml.tmpl
+++ b/releasetasks/templates/desktop/updates.yml.tmpl
@@ -26,7 +26,7 @@
                 branch: "{{ repo_path }}"
                 revision: "{{ mozharness_changeset }}"
             properties:
-                product: "{{ product }}"
+                product: firefox
                 version: "{{ version }}"
                 appVersion: "{{ appVersion }}"
                 build_number: {{ buildNumber }}

Comment 7

[Rail Aliiev [:rail]]

the hack didn't work https://archive.mozilla.org/pub/devedition/tinderbox-builds/jamun-noarch/release-jamun-devedition_updates-bm73-build1-build11.txt.gz because the "product" property is set in the builder and probably overrides the one I tried to pass.

Comment 8

[Rail Aliiev [:rail]]

Worst case scenario, we can generate and bump the config manually, then generate the update verify configs, commit, tag, push. Until we fix this.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

* https://hg.mozilla.org/users/raliiev_mozilla.com/tools/rev/5a4fda38c77d swapped back to <Devedition> in the patcher config, which allowed it to be bumped (build 10)
* granted stage-ffxbld permissions for Devedition product in staging Balrog  (will need to do this in production for ffxbld)
* now it's stuck on 
    Caught HTTPError: {"data": ["Blob contains forbidden domain(s)"]}
  presumably because no 'ftp.stage.mozaws.net' in  
    https://github.com/mozilla/balrog/blob/master/uwsgi/admin.wsgi#L9
  or staging equivalent

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

https://github.com/mozilla/balrog/pull/319 for the last point. Made a note about permissions in bug 1366326.

Comment 11

[Rail Aliiev [:rail]]

Attachment: Bug 1365590 - Pass --stage-product to patcher config bumper a=release DONTBUILD

Review commit: https://reviewboard.mozilla.org/r/142382/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142382/

Comment 12

[Rail Aliiev [:rail]]

Staging bump: https://hg.mozilla.org/users/raliiev_mozilla.com/tools/rev/885fe753f8fc

Comment 13

[[e-mail] (:bhearsum)]

Comment on attachment 8870820 [details]
Bug 1365590 - Pass --stage-product to patcher config bumper  a=release DONTBUILD

https://reviewboard.mozilla.org/r/142382/#review146012

Comment 14

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 0eb7d1afe583 -d 615b7a5a2568: rebasing 398070:0eb7d1afe583 "Bug 1365590 - Pass --stage-product to patcher config bumper r=bhearsum a=release DONTBUILD" (tip)
other [source] changed testing/mozharness/configs/releases/updates_firefox_devedition.py which local [dest] deleted
use (c)hanged version, leave (d)eleted, or leave (u)nresolved? u
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8435ae0f9e97
Pass --stage-product to patcher config bumper r=bhearsum a=release DONTBUILD

Comment 16

[Rail Aliiev [:rail]]

Comment on attachment 8870820 [details]
Bug 1365590 - Pass --stage-product to patcher config bumper  a=release DONTBUILD

https://hg.mozilla.org/integration/mozilla-inbound/rev/8435ae0f9e977562a8f0ce54fe09cfcf7e389b97

Comment 17

[Rail Aliiev [:rail]]

and beta: https://hg.mozilla.org/releases/mozilla-beta/rev/b3b1b2125fc0b242026a926b1db8c7f23330cc99

Comment 18

[Rail Aliiev [:rail]]

Attachment: Bug 1365590 - add patcher config for DevEdition

This is just to make the first release bump happy. We'll need to delete the
fake releases from the config after we ship the first real release.

Review commit: https://reviewboard.mozilla.org/r/142456/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142456/

Comment 19

[[e-mail] (:bhearsum)]

Comment on attachment 8870883 [details]
Bug 1365590 - add patcher config for DevEdition

https://reviewboard.mozilla.org/r/142456/#review146160

Comment 20

[Rail Aliiev [:rail]]

Comment on attachment 8870883 [details]
Bug 1365590 - add patcher config for DevEdition

https://hg.mozilla.org/build/tools/rev/426c2e99074526871b727fb483db496f9f5b37f1

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8435ae0f9e97

Comment 22

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.