1365646 - logic error makes it impossible ot run a single lint job

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

-b o -p lint -j mozharness

should run the mozharness lint job (as long as you add a trivial change to mozharness so it doesn't get optimized away).

But it doesn't, and I think the cause is a logic error.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=999bc2c54b7fd25a87662d6eaec26c7801055b5a

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=44a56984d25cda343bc7f72e7a895174c1fb49e8

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1365646: fix logic error in try syntax `-j` handling;

Review commit: https://reviewboard.mozilla.org/r/140228/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140228/

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8868646 [details]
Bug 1365646: fix logic error in try syntax `-j` handling;

https://reviewboard.mozilla.org/r/140228/#review144328

Comment 5

[Mozilla Autoland]

hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: Rev 63db04758d1f uses try syntax. (Did you mean to push to Try instead?)
remote: Dustin J. Mitchell <[e-mail]>
remote: Bug 1365646: fix logic error in try: -j handling; r=gps
remote: 
remote: MozReview-Commit-ID: ApKmq9IYRtV
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.c_commitmessage hook failed
abort: push failed on remote

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Gah, bstack ran into that once, too.  Stupid hooks.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8868646 [details]
Bug 1365646: fix logic error in try syntax `-j` handling;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/140228/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e31fadbf7f02
fix logic error in try syntax `-j` handling; r=gps

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e31fadbf7f02