Update fixed items at top of synced tabs item in library panel to have icons, correct indenting

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Toolbars and Customization
P1
normal
VERIFIED FIXED
3 months ago
20 days ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

(Blocks: 2 bugs)

53 Branch
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 verified)

Details

(Whiteboard: [photon-structure])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
The spec has an item for the synced tabs. It should do the same thing the current synced tabs button in the hamburger panel does.
(Assignee)

Updated

3 months ago
Flags: qe-verify+
Whiteboard: [photon-structure]

Updated

3 months ago
Priority: -- → P2
QA Contact: gwimberly
(Assignee)

Comment 1

2 months ago
Aaron, can you test the current version of the synced tabs item in the library panel and check if we still need to do anything here (besides the width of the library panel and this on current nightly - should be fixed by bug 1370580, you can test with the main hamburger panel's library entry for now) ?

Per comment #0 (and looking at the spec), I believe this should be done now, as we're just reusing the same thing we already had. The only thing I see is some remaining styling issues (mostly missing icons for the fixed items at the top, and the indenting of those items). If that's right, I can update the summary here to clarify.
Flags: needinfo?(abenson)

Comment 2

2 months ago
Yeah, this looks great! :)
Flags: needinfo?(abenson)
(Assignee)

Comment 3

2 months ago
Thanks!
Summary: Add a synced tabs item to the library panel → Update fixed items at top of synced tabs item in library panel to have icons, correct indenting
(Assignee)

Updated

2 months ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 56.1 - Jun 26
Priority: P2 → P1
Comment hidden (mozreview-request)

Comment 5

2 months ago
mozreview-review
Comment on attachment 8878473 [details]
Bug 1365663 - update synced tabs panel view iconography and alignment,

https://reviewboard.mozilla.org/r/149828/#review155084

LGTM! Thanks!

::: browser/themes/shared/customizableui/panelUI.inc.css:1259
(Diff revision 1)
>  
>  photonpanelmultiview .subviewbutton:focus {
>    outline: 0;
>  }
>  
> +photonpanelmultiview .subviewbutton:not(.subviewbutton-back) > .toolbarbutton-text {

Hmm, perhaps the back buttons' .toolbarbutton-text should just be display: none?
Feel free to include that in this patch, if it makes sense.
Attachment #8878473 - Flags: review?(mdeboer) → review+
Comment hidden (mozreview-request)

Comment 7

2 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/909c1f2a6f21
update synced tabs panel view iconography and alignment, r=mikedeboer

Comment 8

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/909c1f2a6f21
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
(Assignee)

Updated

2 months ago
Depends on: 1374650

Comment 9

2 months ago
I can see "a synced tabs item is add in the library panel and have icon," in latest Nightly 56.0a1 on ubuntu 16.04 , 64bit.


Build ID 	20170620100236
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170621]

Comment 10

2 months ago
I have reproduced this Bug on Nightly 55.0a1 (2017-05-17) on Windows 10, 64 Bit!

The bug's fix is now verified on latest  Nightly 56.0a1

Build ID    :	20170620030208
User Agent  : 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

[bugday-20170621]
Verified on Windows, Mac, and Ubuntu.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
Flags: qe-verify+
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.