Closed
Bug 1365711
Opened 7 years ago
Closed 7 years ago
Set GeckoInterface from GeckoApplication
Categories
(GeckoView :: General, enhancement)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(1 file)
|
12.57 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
With what remains of GeckoInterface, we can set the GeckoInterface instance once inside GeckoApplication, and not worry about it again when using multiple GeckoApps/GeckoViews.
|
Assignee | |
Comment 1•7 years ago
|
||
Now that GeckoInterface only contains openUriExternal and getHandlersFor* methods, we can set GeckoInterface from GeckoApplication only, and not GeckoApp or GeckoView. This also lets us get rid of BaseGeckoInterface.
Attachment #8868707 -
Flags: review?(snorp)
Comment on attachment 8868707 [details] [diff] [review] Set GeckoInterface from GeckoApplication (v1) Review of attachment 8868707 [details] [diff] [review]: ----------------------------------------------------------------- Hooray!
Attachment #8868707 -
Flags: review?(snorp) → review+
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/35d857a41a7b Set GeckoInterface from GeckoApplication; r=snorp
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/35d857a41a7b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•6 years ago
|
Assignee: nobody → nchen
|
||
Updated•5 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•5 years ago
|
Target Milestone: Firefox 55 → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•