1365822 - stylo: github's search box doesn't have correct padding

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Shing Lyu [:shinglyu]]

Attachment: Stylo no padding screenshot

STR:
* Open https://www.github.com/servo/servo
* Type a very long string into the "This repository" search box
* Observe the right side padding of the box

Expected:
* There should be a padding at the right, roughly the same width as the left side padding

Actual:
* In stylo there is no such padding

Note:
The search box uses "box-sizing: border-box", which might be the cause of the bug

Comment 1

[Shing Lyu [:shinglyu]]

Attachment: Gecko padded screenshot

Comment 2

[Cameron McCormack (:heycam)]

I think I've finally narrowed this down to overflow-clip-box declarations from the UA style sheet not taking effect on the <input>'s anonymous div:

19:3 Unsupported property declaration: 'overflow-clip-box: inherit;', found unexpected identifier inherit
111:3 Unsupported property declaration: 'overflow-clip-box: content-box;', found unexpected identifier content-box
160:3 Unsupported property declaration: 'overflow-clip-box: content-box;', found unexpected identifier content-box
184:3 Unsupported property declaration: 'overflow-clip-box: inherit;', found unexpected identifier inherit
271:3 Unsupported property declaration: 'overflow-clip-box: padding-box !important;', found unexpected delimiter !
499:3 Unsupported property declaration: 'overflow-clip-box: padding-box;', found unexpected identifier padding-box
653:3 Unsupported property declaration: 'overflow-clip-box: padding-box;', found unexpected identifier padding-box
141:3 Unsupported property declaration: 'overflow-clip-box: inherit;', found unexpected identifier inherit
156:3 Unsupported property declaration: 'overflow-clip-box: inherit;', found unexpected identifier inherit
175:3 Unsupported property declaration: 'overflow-clip-box: inherit;', found unexpected identifier inherit
223:3 Unsupported property declaration: 'overflow-clip-box: inherit;', found unexpected identifier inherit

Haven't yet looked into why.

Comment 3

[Cameron McCormack (:heycam)]

It's an incorrect interaction between internal="True" and the property having a pref.

Comment 4

[Cameron McCormack (:heycam)]

Fixed by bug 1375374.