Reset app.update.cancelations on successful elevation

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Application Update
P2
normal
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Just noticed the misspelling and that the preference is being reset on successful elevation on Windows. Now that Windows behaves as Mac OS X where we prompt the user to download an update after X number of cancellations this is important.
That is actually a valid spelling so let's not bother rename it unless it is dirt simple.
Summary: Rename app.update.cancelations to app.update.cancellations and reset it on successful elevation → Reset app.update.cancelations on successful elevation
I *think* this only affects Windows
Can you clarify this a bit more? I'm not sure I understand. I see that we're incrementing the cancelations pref on every elevation failure, and only resetting it on non-elevation failures (i.e., not on elevation success), but this pref only seems to be used for telemetry. Am I missing something? We use the app.update.elevate.attempts pref to control the doorhanger (this pref should probably just merge with the cancelations pref - I'm not sure why I introduced it in the first place.)
Flags: needinfo?(robert.strong.bugs)
This isn't directly due to your patch... it has to do with the new UI handling this pref the same way as OS X is handled. I'll take this bug since I'm familiar with the code paths and I might want to tweak it some.
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Flags: needinfo?(robert.strong.bugs)
Created attachment 8874714 [details] [diff] [review]
patch rev1
Attachment #8874714 - Flags: review?(mhowell)

Updated

6 months ago
Attachment #8874714 - Flags: review?(mhowell) → review+

Comment 6

6 months ago
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9948661fdb33
Reset app.update.cancelations after a successful update. r=mhowell

Comment 7

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9948661fdb33
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.