1365896 - Same math on luminosity resulting different highlight colors b/t different xul:labels

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Screen Shot 2017-05-18 at 6.42.50 PM.png

This is the result from bug 1365869. It's pretty fun, because the math is the same.

I suspect the input are different though, but have not yet figure that out. One of the colors nsTextPaintStyle::InitCommonColors() gets from other functions should be different between these two xul:labels.

This is unrelated to Selection#setColors() because removing the customs colors doesn't remove the difference. You can try that by using devtools and `gSearchResultsPane.findSelection.resetColors()`. So I decided to file a separate bug from bug 1365869.

(We have never use SELECTION_FIND on XUL documents I guess? If so there should be an existing bug on this)

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

BTW, the high contrast is simulated by using the color sub-dialog in pref. Set the text color to white and background color to black, uncheck "use system color", and set overwrite to "always".

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I've found the cause there. The default -moz-appearance set on xul|checkbox and xul|radio will make nsTextPaintStyle::InitCommonColors() return early. This can be easily fixed by overwriting it.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1365896 - Set -moz-appearance to none on in-content xul|checkbox and xul|radio,

This patch should not result any visual differences. Rather, it makes
nsTextPaintStyle::InitCommonColors() think the checkboxes and radio
buttons are not themed and it should calculate contrast properly.

Review commit: https://reviewboard.mozilla.org/r/140878/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140878/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8869328 [details]
Bug 1365896 - Set -moz-appearance to none on in-content xul|checkbox and xul|radio,

https://reviewboard.mozilla.org/r/140878/#review145188

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df65e023bd5a
Set -moz-appearance to none on in-content xul|checkbox and xul|radio, r=jaws

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/df65e023bd5a