stylo: Parsing for @font-feature-values

ASSIGNED
Assigned to

Status

()

Core
CSS Parsing and Computation
P2
normal
ASSIGNED
10 days ago
5 days ago

People

(Reporter: jeremychen, Assigned: jeremychen)

Tracking

(Blocks: 2 bugs)

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

10 days ago
Separate the parsing part to here.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 6

5 days ago
Comment on attachment 8868976 [details]
Bug 1365900 - (wip) add initial style system support for @font-feature-falues rule.

The most different part of @font-feature-values rule is that it may contain nested @rules blocks, such like:

@font-feature-values font1 {
  @swash {
    ident1: 2;
    ident2: 4;
  }
}

I tried to reuse the existing parsing codes for 1-level @rule parser and wrote this patch. Since I'm not very familiar with Rust and macro_rules stuff, so I think it would be better to gather some feedback before going further.

Xidorn, could you take a look and give me some feedback? Do you think this patch is toward the right direction? If you're not comfortable with giving feedback on this pure Rust patch, please feel free to pass the request to Emilio or Simon, thank you.
Attachment #8868976 - Flags: feedback?(xidorn+moz)
Comment hidden (mozreview-request)
(Assignee)

Updated

5 days ago
Attachment #8868976 - Flags: feedback?(xidorn+moz)
Comment on attachment 8868976 [details]
Bug 1365900 - (wip) add initial style system support for @font-feature-falues rule.

I myself don't write lots of parser stuff. Most of parser bits of my previous work were written by Simon, so I redirect f? to him.
Attachment #8868976 - Flags: feedback?(xidorn+moz) → feedback?(simon.sapin)
You need to log in before you can comment on or make changes to this bug.