Closed Bug 1365902 Opened 3 years ago Closed 3 years ago

stylo: Make RebuildAllStyleData asynchronous.

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I tried this a while ago, and couldn't but that was jut because of the font stuff was before the UpdateStylistIfNeeded code.

So I don't see no reason to not do it that way.
Comment on attachment 8868978 [details]
Bug 1365902: Make ServoStyleSet::RebuildAllStyleData async.

https://reviewboard.mozilla.org/r/140654/#review144444

::: layout/base/ServoRestyleManager.cpp
(Diff revision 1)
> -  // NOTE(emilio): GeckoRestlyeManager does a sync style flush, which seems
> -  // not to be needed in my testing.

Probably worth preserving this comment, since GeckoRestyleManager is still doing this sync.
Attachment #8868978 - Flags: review?(cam) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8bcc71a220fc
Make ServoStyleSet::RebuildAllStyleData async. r=heycam
https://hg.mozilla.org/mozilla-central/rev/8bcc71a220fc
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.