1365902 - stylo: Make RebuildAllStyleData asynchronous.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

I tried this a while ago, and couldn't but that was jut because of the font stuff was before the UpdateStylistIfNeeded code.

So I don't see no reason to not do it that way.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=80b09a0d45733225adf475e12a59e59348d7d710&selectedJob=99843995

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1365902: Make ServoStyleSet::RebuildAllStyleData async.

Review commit: https://reviewboard.mozilla.org/r/140654/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140654/

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8868978 [details]
Bug 1365902: Make ServoStyleSet::RebuildAllStyleData async.

https://reviewboard.mozilla.org/r/140654/#review144444

::: layout/base/ServoRestyleManager.cpp
(Diff revision 1)
> -  // NOTE(emilio): GeckoRestlyeManager does a sync style flush, which seems
> -  // not to be needed in my testing.

Probably worth preserving this comment, since GeckoRestyleManager is still doing this sync.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8868978 [details]
Bug 1365902: Make ServoStyleSet::RebuildAllStyleData async.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/140654/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bcc71a220fc
Make ServoStyleSet::RebuildAllStyleData async. r=heycam

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8bcc71a220fc