1365934 - Update webrender to 76a3213080ca5c2e2a612c3023c50c81a111fd55

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1364993 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ 6af60ceb9c53bace4afbaa6869c52ce2a0004477

https://treeherder.mozilla.org/#/jobs?repo=try&revision=03385d696dafcf703439bab46d1566b0588c0fb1

Busted, gl() function missing?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

WR @ c003d553bdd856e1e78d213375582a1f2b091a06 with readback fixup

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8affa073d9b5e18f4e1269e7e179b94c07d9e23

Green

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR @ ecd8416af7234c14c96074c2f1cb3fe72325b050

https://treeherder.mozilla.org/#/jobs?repo=try&revision=77762d477bb91b5894f926db20b832ab907bb325

R4 debug-only failure, it's a rust_panic coming from texture_cache::FreeListBin::for_size [1]. Regression range is:

*   ecd8416 Auto merge of #1271 - kvark:tex-cache, r=glennw
|\
| * 031419d Moved coalesce vertical/horisontal passes into separate methods
| * 2bd4f5d Coalesce benchmark
| * ad6ed1b Removing allocation from coalesce implementation
| * e83633e Removing indexing from coalesce inner loops
* 5d9875a Auto merge of #1268 - nical:stacktraces, r=glennw
* c0e86a2 Show backtraces in case of unit test failure.

Almost certainly a regression from servo/webrender#1271 as that seems to touch the free list code. I'll comment on that issue.

[1] https://treeherder.mozilla.org/logviewer.html#?job_id=100843761&repo=try&lineNumber=6967

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ 509873da3578821a70b50b81a5aaa1d263698328

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3986678adc4b0af607b843672ddc19b1573fd897

Same R4 failure as before, nothing else new.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ 42c043601b076528f6e7a3f96653d693ea09a12a

https://treeherder.mozilla.org/#/jobs?repo=try&revision=427e1921942a45d5b9d35edd478871160ec80541

Same R4

Comment 6

[Kartikaya Gupta (email:[e-mail])]

WR @ 19c154eb35d44c90e4f825310306eeaeff7db30f

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb6171fce673bb40654cf27f9d291c8ca8b811d3

Back to green, as it includes the fix from servo/webrender#1287

Comment 7

[Kartikaya Gupta (email:[e-mail])]

WR @ 19c154eb35d44c90e4f825310306eeaeff7db30f

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cae08508343ef87508d1224d28c725b0f1d5c2e6

Green

Comment 8

[Kartikaya Gupta (email:[e-mail])]

WR @ 76a3213080ca5c2e2a612c3023c50c81a111fd55

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f10638cab418b982877433c158ceaf314c3427bf

Green. Let's do an update, it's been almost a week now.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1365934 - Update webrender to 76a3213080ca5c2e2a612c3023c50c81a111fd55.

Review commit: https://reviewboard.mozilla.org/r/142742/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142742/

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1365934 - Update the readback function for an API change in 052b0a7.

Review commit: https://reviewboard.mozilla.org/r/142744/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142744/

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8871255 [details]
Bug 1365934 - Update webrender to 76a3213080ca5c2e2a612c3023c50c81a111fd55.

https://reviewboard.mozilla.org/r/142742/#review146506

Comment 12

[Dzmitry Malyshau [:kvark]]

Comment on attachment 8871256 [details]
Bug 1365934 - Update the readback function for an API change in 052b0a7.

https://reviewboard.mozilla.org/r/142744/#review146556

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/3d821b8e5cbf
Update webrender to 76a3213080ca5c2e2a612c3023c50c81a111fd55. r=jrmuizel,kvark

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3d821b8e5cbf