1365986 - fix imports in extract_and_run_command.py logic

Status: RESOLVED WORKSFORME

(Release Engineering :: Applications: MozharnessCore, enhancement, P2)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

We've had this error for a while and we just noticed it. We need to fix a bunch of things. This is not blocking devedition as it currently affects the other releases as well.

16:46:20 <rail> also for some reason we get "ImportError: No module named mar" there
16:46:37 <mtabara> yeah, was just reading that 
16:46:48 <mtabara> during scan-bits step
16:47:05 <mtabara> hm, I wonder if yesterday graph had similar error 
16:49:40 <rail> oh, I think it should be mardor not mar
16:53:14 <rail> hmm, https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/external_tools/extract_and_run_command.py#34-41 looks safe enough...
16:53:21 <mtabara> https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/external_tools/extract_and_run_command.py
16:53:25 <mtabara> hasn't changed in a year 
16:56:46 <rail> probably the API changed
16:56:59 <mtabara> rail: hm, the tasks from yesterday had the same error but moved passed by it - see https://public-artifacts.taskcluster.net/nc84zM1-QI2cehxc6BMZiw/0/public/logs/live_backing.log 
16:57:14 <mtabara> however, I agree, we should fix that
16:58:52 <rail> so we have 3 issues: 1) need to update the imports to match the new API 2) pin the version so we don't hit in the future 3) check the return code of the call and fail it's not 0

Comment 2

[Rail Aliiev [:rail]]

We should change the import to something like 

from mardor.reader import MarReader

then in https://dxr.mozilla.org/mozilla-central/rev/7d15bc419c6cd7e9f3b4d41370c3b0e5990c8d1b/testing/mozharness/external_tools/extract_and_run_command.py#47-48

    with open(mar, 'rb') as mar_fh:
        m = MarReader(mar_fh)
        m.extract(destdir=tempdir)

And test :)

Comment 4

[Chris AtLee [:catlee]]

Beetmoving should also fail if this command fails.

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

Bumping priority here as this seems to hit us more than we'd like.

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

We haven't hit this in a good while, closing this.