Build Stylo for win32 and win64

RESOLVED FIXED in Firefox 56

Status

()

P2
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: froydnj, Assigned: gps)

Tracking

Trunk
mozilla56
All
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
This is a matter of getting a Rust with support for `thiscall`:

https://github.com/rust-lang/rust/pull/42058

(not merged or even reviewed at the time of this writing) and then propagating that knowledge into syntex and from there into bindgen.
Blocks: 1356991
No longer blocks: 1243581
Priority: -- → P2
Because of the time to ship thiscall support in Rust and syntex, we aren't going to block Stylo built-but-disabled waiting for win32 support.
Blocks: 1330412
No longer blocks: 1356991
Depends on: 1365254
Blocks: 1345321, 1356991
No longer blocks: 1330412
Emilio landed a workaround in rust-bindgen so it doesn't panic when parsing the unrecognized thiscall calling convention. When servo upgrades to a new rust-bindgen release, we should then be able to build Stylo for Win32.

https://github.com/servo/rust-bindgen/pull/722
(Assignee)

Comment 3

2 years ago
Did this bug get sorted out as part of bug 1365254?
(In reply to Gregory Szorc [:gps] from comment #3)
> Did this bug get sorted out as part of bug 1365254?

You can use this bug for actually enabling Stylo builds for win32 and win64. That bug just fixed a win32 build problem.
Assignee: nobody → gps
Summary: enable Stylo for 32-bit Windows → Build Stylo for win32 and win64
Comment hidden (mozreview-request)
(Reporter)

Comment 6

2 years ago
mozreview-review
Comment on attachment 8880148 [details]
Bug 1366048 - Build stylo on win32 and win64 in automation;

https://reviewboard.mozilla.org/r/151522/#review156486

\o/
Attachment #8880148 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 7

2 years ago
I'm going to hold off landing this until we know the backout service works.
(Assignee)

Comment 8

2 years ago
We're still having some issues with VCS backout syncing. Rather than land this and increase the odds of things breaking, I'm going to wait until things are in a better state, likely by the middle of next week at the latest. Plus some regressions from Linux64 are still being worked out. Plus it is a Friday and I don't like fire fighting on the weekend.
No longer blocks: 1345321
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED

Comment 9

2 years ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/06ec956f7533
Build stylo on win32 and win64 in automation; r=froydnj

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/06ec956f7533
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
This caused a 1.9 MB jump in installer size on Win 64 PGO.
(Assignee)

Comment 12

a year ago
(In reply to Kevin Brosnan [:kbrosnan] from comment #11)
> This caused a 1.9 MB jump in installer size on Win 64 PGO.

That was expected (we're building/shipping new code) and is similar to what was seen on Linux (see bug 1374824 comment 22).

I can't answer whether that is a reasonable amount of size increase. (It probably is.)
(Assignee)

Updated

a year ago
Blocks: 1384759
You need to log in before you can comment on or make changes to this bug.