Closed Bug 1366048 Opened 3 years ago Closed 3 years ago

Build Stylo for win32 and win64

Categories

(Core :: CSS Parsing and Computation, defect, P2)

All
Windows
defect

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: froydnj, Assigned: gps)

References

Details

Attachments

(1 file)

This is a matter of getting a Rust with support for `thiscall`:

https://github.com/rust-lang/rust/pull/42058

(not merged or even reviewed at the time of this writing) and then propagating that knowledge into syntex and from there into bindgen.
Blocks: stylo-nightly-build
No longer blocks: stylo
Priority: -- → P2
Because of the time to ship thiscall support in Rust and syntex, we aren't going to block Stylo built-but-disabled waiting for win32 support.
Blocks: stylo-nightly
No longer blocks: stylo-nightly-build
Depends on: 1365254
Emilio landed a workaround in rust-bindgen so it doesn't panic when parsing the unrecognized thiscall calling convention. When servo upgrades to a new rust-bindgen release, we should then be able to build Stylo for Win32.

https://github.com/servo/rust-bindgen/pull/722
Did this bug get sorted out as part of bug 1365254?
(In reply to Gregory Szorc [:gps] from comment #3)
> Did this bug get sorted out as part of bug 1365254?

You can use this bug for actually enabling Stylo builds for win32 and win64. That bug just fixed a win32 build problem.
Assignee: nobody → gps
Summary: enable Stylo for 32-bit Windows → Build Stylo for win32 and win64
Comment on attachment 8880148 [details]
Bug 1366048 - Build stylo on win32 and win64 in automation;

https://reviewboard.mozilla.org/r/151522/#review156486

\o/
Attachment #8880148 - Flags: review?(nfroyd) → review+
I'm going to hold off landing this until we know the backout service works.
We're still having some issues with VCS backout syncing. Rather than land this and increase the odds of things breaking, I'm going to wait until things are in a better state, likely by the middle of next week at the latest. Plus some regressions from Linux64 are still being worked out. Plus it is a Friday and I don't like fire fighting on the weekend.
No longer blocks: stylo-tooling
Status: NEW → ASSIGNED
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/06ec956f7533
Build stylo on win32 and win64 in automation; r=froydnj
Depends on: 1378667
https://hg.mozilla.org/mozilla-central/rev/06ec956f7533
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Depends on: 1378791
This caused a 1.9 MB jump in installer size on Win 64 PGO.
(In reply to Kevin Brosnan [:kbrosnan] from comment #11)
> This caused a 1.9 MB jump in installer size on Win 64 PGO.

That was expected (we're building/shipping new code) and is similar to what was seen on Linux (see bug 1374824 comment 22).

I can't answer whether that is a reasonable amount of size increase. (It probably is.)
Blocks: 1384759
You need to log in before you can comment on or make changes to this bug.