136606 - crash when navigating this page via keyboard

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Kathleen :Brade]

I am crashing when I go to this url:
http://bugzilla.mozilla.org/attachment.cgi?id=78364&action=view

1) click checkbox
2) press tab
3) press tab
4) press down arrow

Notice assertion:  You can't dereference a NULL nsCOMPtr with operator->().

nsListControlFrame::IsOptionDisabled
nsListControlFrame::AdjustIndexForDisabledOpt
nsListControlFrame::KeyPress
nsListEventListener::KeyPress
nsEventListenerManager::HandleEvent
...


I was testing rods' patch in bug 64165 when I came across this; I see the crash
without his patch as well.  This bug is blocking my testing of his patch.

Comment 1

[Kevin McCluskey (gone)]

nsbeta1+

Comment 2

[Kevin McCluskey (gone)]

[adt2]

Comment 3

[John Keiser (jkeiser)]

Attachment: Patch

This patch fixes the problem.  It is sort-of-wallpapering; the
AdjustIndexForDisabledOpt() algorithm is broken and should not be asking for
nonexistent options, and I know how to fix it, but (1) such a fix should not go
into a 1.0 build--unnecessary risk--and (2) such a fix doesn't *need* to go
into the trunk--XBL Form Controls will soon take over the world there.

Comment 4

[rods (gone)]

Comment on attachment 79711 [details] [diff] [review]
Patch

r=rods

Comment 5

[Marc Attinasi]

Comment on attachment 79711 [details] [diff] [review]
Patch

Cool -- so this works now, eh? I guess moving form submission to content makes
this possible, very nice.

Comment 6

[John Keiser (jkeiser)]

Attachment: Patch, really

Apologies to both of you, that wasn't the patch I meant to attach.  I don't
know how old that particular css file is, but I guess it works since I've
surfed on that build for a while :)

Comment 7

[rods (gone)]

Comment on attachment 79848 [details] [diff] [review]
Patch, really

r=rods

Comment 8

[Marc Attinasi]

Comment on attachment 79848 [details] [diff] [review]
Patch, really

sr=attinasi

Comment 9

[John Keiser (jkeiser)]

checked in to trunk.

Comment 10

[Terri Preston]

Verified fixed Mac OS 9.1 trunk build 2002041903

Comment 11

[Terri Preston]

duh, marking verified

Comment 12

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) approval for checking into the 1.0 branch. Pls check
this in today, then add the fixed1.0.0 keyword.

Also, if not already done, pls file a bug for the real fix to this problem.

Comment 13

[John Keiser (jkeiser)]

It is not my intent to actually fix the real problem.  There is no longer a
reason to do so.  No need to clutter the bug system with it.

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

refresh a=[e-mail] for branch checkin

Comment 15

[John Keiser (jkeiser)]

Checked in to branch.

Comment 16

[Terri Preston]

Verified fixed Mac OS 9 branch build 20020522

Comment 17

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381