1366098 - Remove tab type/activity switching infrastructure again

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Jan Henning [:JanH]]

With the advent of GeckoView-based custom tabs/web apps, this'll have outlived its usefulness again and should be removed again while I can still easily remember what I added in the first place.

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1366098 - Part 0 - Clean up imports.

Review commit: https://reviewboard.mozilla.org/r/155460/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155460/

Comment 2

[Jan Henning [:JanH]]

Attachment: Bug 1366098 - Part 1 - Remove Fennec tab type infrastructure.

The new, preferred solution for displaying additional web content outside of our normal tab infrastructure and UI is to use a separate GeckoView instance. Therefore, the support for different having additional "tab" types that aren't displayed in the normal UI, as well as for multiple GeckoApp instances displaying different tabs is no longer needed and can be removed.

Review commit: https://reviewboard.mozilla.org/r/155456/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155456/

Comment 3

[Julian Chu [:walkingice]]

Comment on attachment 8884568 [details]
Bug 1366098 - Part 0 - Clean up imports.

https://reviewboard.mozilla.org/r/155460/#review160598

Comment 4

[Julian Chu [:walkingice]]

Comment on attachment 8884569 [details]
Bug 1366098 - Part 1 - Remove Fennec tab type infrastructure.

https://reviewboard.mozilla.org/r/155456/#review160642

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s b1fd9592d9ff -d 1da791db18e3: rebasing 406365:b1fd9592d9ff "Bug 1366098 - Part 0 - Clean up imports. r=walkingice"
rebasing 406366:0db1fe7abc38 "Bug 1366098 - Part 1 - Remove Fennec tab type infrastructure. r=walkingice" (tip)
merging mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
merging mobile/android/base/moz.build
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/BrowserApp.java! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Jan Henning [:JanH]]

Comment on attachment 8884568 [details]
Bug 1366098 - Part 0 - Clean up imports.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155460/diff/1-2/

Comment 7

[Jan Henning [:JanH]]

Comment on attachment 8884569 [details]
Bug 1366098 - Part 1 - Remove Fennec tab type infrastructure.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155456/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3dfecf450c3f
Part 0 - Clean up imports. r=walkingice
https://hg.mozilla.org/integration/autoland/rev/3ff253372a1b
Part 1 - Remove Fennec tab type infrastructure. r=walkingice

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3dfecf450c3f
https://hg.mozilla.org/mozilla-central/rev/3ff253372a1b