1366215 - InvalidStateError errors logged when installing webextensions from aboutdebugging tests

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect, P3)

Description

[Julian Descottes [:jdescottes]]

aboutdebugging tests are logging errors when installing webextensions:

Code using the addon manager:

> AddonManager.getInstallForFile(filePath, install => {
>   if (!install) {
>     throw new Error(`An install was not created for ${filePath}`);
>   }
>   install.addListener({
>     onDownloadFailed: reject,
>     onDownloadCancelled: reject,
>     onInstallFailed: reject,
>     onInstallCancelled: reject,
>     onInstallEnded: resolve
>   });
>   install.install();
> });

(http://searchfox.org/mozilla-central/rev/24c443a440104dabd9447608bd41b8766e8fc2f5/devtools/client/aboutdebugging/test/browser_addons_reload.js#43-59)

Stack trace:

> 32 INFO Console message: [JavaScript Error: "InvalidStateError: A mutation operation was attempted on a database that did not allow mutations."]
> transaction@resource://gre/modules/IndexedDB.jsm:294:39
> objectStore@resource://gre/modules/IndexedDB.jsm:322:23
> get@resource://gre/modules/ExtensionUtils.jsm:153:7
> async*parseManifest@resource://gre/modules/Extension.jsm:807:12
> loadManifest@resource://gre/modules/Extension.jsm:495:7
> async*loadManifest@resource://gre/modules/Extension.jsm:812:12
> _startup@resource://gre/modules/Extension.jsm:960:42
> async*startup@resource://gre/modules/Extension.jsm:952:27
> startup@resource://gre/modules/addons/XPIProvider.jsm -> resource://gre/modules/addons/WebExtensionBootstrap.js:29:3
> callBootstrapMethod@resource://gre/modules/addons/XPIProvider.jsm:5364:11
> startInstall/<@resource://gre/modules/addons/XPIProvider.jsm:6258:13
> async*startInstall@resource://gre/modules/addons/XPIProvider.jsm:6158:6
> install@resource://gre/modules/addons/XPIProvider.jsm:5811:7
> install@resource://gre/modules/addons/XPIProvider.jsm:6502:5
> checkForBlockers@resource://gre/modules/addons/XPIProvider.jsm:6116:5
> install@resource://gre/modules/addons/XPIProvider.jsm:5808:7
> install@resource://gre/modules/addons/XPIProvider.jsm:6502:5
> checkPrompt/<@resource://gre/modules/addons/XPIProvider.jsm:6091:7
> async*checkPrompt@resource://gre/modules/addons/XPIProvider.jsm:6071:6
> install@resource://gre/modules/addons/XPIProvider.jsm:5805:7
> install@resource://gre/modules/addons/XPIProvider.jsm:6502:5
> install@resource://gre/modules/addons/XPIProvider.jsm:7052:5
> installAddonWithManager/</<@chrome://mochitests/content/browser/devtools/client/aboutdebugging/test/head.js:474:7

Comment 1

[Julian Descottes [:jdescottes]]

The extension code that throws is in ExtensionUtils.jsm

> db.objectStore(this.storeName, "readwrite")
>   .put(result);

http://searchfox.org/mozilla-central/source/toolkit/components/extensions/ExtensionUtils.jsm#153-154

when calling StartupCache.manifests.get

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

We migrated away from IndexedDB as a backend for the StartupCache long time ago (from Firefox 56, around the time this bug has been filed, See Bug 1364768) and so this bug shouldn't be relevant anymore.

The underlying issue is likely the same as Bug 1633209, but I'm closing this particular issue as fixed and adding Bug 1364768 as a dependency for this issue because this one isn't going to be triggered anymore.