136634 - Shift+F10/Ctrl+Space/windows' Context-menu key a second time (more than once) should NOT close the context menu

Status: NEW

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Matthew T (active 1999-2002)]

To reproduce:
1.  Focus the content area, if it is not focused already.
2.  Type Ctrl+Space (Mac OS) or Shift+F10 (Linux), so that the shortcut menu
    opens.
3.  Type Ctrl+Space or Shift+F10 again.

What should happen:
*   The menu closes.

What happens:
*   Nothing.

Problem occurs with:
*   build 2002040508, Mac OS 9.2
*   build 20020404, Red Hat Linux 7.2

Problem does not occur with:
*   build 2002040903, Windows 2000

Comment 1

[Jesse Ruderman]

On Windows 98:

- With the context menu key, pressing it again doesn't make the context menu
close.  This is how other Windows apps work.

- With Shift+F10, pressing it again makes the context menu close, but pressing
it a third time doesn't make the context menu reappear.  Pressing it a fourth
time makes it reappear.

Comment 2

[:deanis74]

Jesse: I just noticed the Shift+F10 bug on Windows.  I'd file a new bug on that,
I think it's separate from this one.

Comment 3

[Wayne Mery (:wsmwk)]

still true on linux?

same thing still happens for windows' context menu key - second press doesn't close the menu

(In reply to comment #1)
> On Windows 98:
> - With Shift+F10, pressing it again makes the context menu close, but pressing
> it a third time doesn't make the context menu reappear.  Pressing it a fourth
> time makes it reappear.

filed bug 371777

Comment 4

[Wayne Mery (:wsmwk)]

Aaron, is there a UI spec on how this should perform?

Focus: In FF2 and Thunderbird 2, the second shift+F10 now closes the menu, but focus does not revert to original location.  On windows, do two shift+F10 and then spacebar and you see focus is on the titlebar's window control, top left.

linux - where is focus after second shift+F10?

Comment 5

[Robert Kaiser]

Shift+F10 or the context menu key do not close a context menu in GTK2 apps, so it also shouldn't do so in Mozilla apps on Linux.

Comment 6

[Wayne Mery (:wsmwk)]

MPT says the menu should close, but the consensus on IRC seems to be that the menu should stay up.  Except MAC, rbgray "thinks that is an unspecified combination, there's probably a UI spec"

Neil says "it should stay open on Windows".   Kairo says "we should do whatever the native toolkit does - if it leaves the cpontext menu open, we should do so as well".  Reiterating comment 0, "context key" on windows keyboard does exactly that, context menu doesn't go away  (MSword, etc)

FWIW
* plain old F10 in all the apps I tested just toggles focus on the menu bar
* safari ignores ctrl+space (per rbgray)

Robert, are you saying current linux mozilla does close menu?

Comment 7

[Wayne Mery (:wsmwk)]

MAC:
Ctrl+Space currently totally broke in cocoa - bug 357540
not sure how/if bug 34572 plays in at all.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Since bug 357540 is fixed this is WFM with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008030404 Minefield/3.0b5pre ID:200803040

Does this still occur under Windows and Linux?

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Pressing Shift+F10 twice under Windows correctly closes the context menu. But doing the same with the context menu key it doesn't work.

Comment 10

[Wayne Mery (:wsmwk)]

perhaps I messed up my keyboard, but ctrl+space isn't doing anything.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Wayne, Ctrl+Space is exclusively for OS X and doesn't work on Windows or Linux.