1366361 - Make form.action return the actual form submission URL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Domenic Denicola]

Tests at http://w3c-test.org/html/semantics/forms/the-form-element/form-action-reflection.html and http://w3c-test.org/html/semantics/forms/the-form-element/form-action-reflection-with-base-url.html

Spec at https://html.spec.whatwg.org/multipage/forms.html#dom-fs-action

Per the separate tests at http://w3c-test.org/html/semantics/forms/the-form-element/form-action-submission.html and http://w3c-test.org/html/semantics/forms/the-form-element/form-action-submission-with-base-url.html, Firefox uses the spec's algorithm for determining the actual URL to which the form submits. However, it does not return the correct URL for form.action.

No browser seems to follow the spec here, but they violate it in different ways, so this is probably safe to change.

Comment 1

[Jessica Jong [:jessica] (inactive)]

The same rule should apply to input.formAction and button.formAction as well:
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#dom-fs-formaction

Comment 2

[Jessica Jong [:jessica] (inactive)]

Attachment: Part 1: add GetAction and GetFormAction implementation.

Comment 3

[Jessica Jong [:jessica] (inactive)]

Attachment: Part 2: update related tests.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8885618 [details] [diff] [review]
Part 1: add GetAction and GetFormAction implementation.

>+HTMLFormElement::GetAction(nsString& aValue)
>+{
>+  if (!GetAttr(kNameSpaceID_None, nsGkAtoms::action, aValue) ||
>+      aValue.IsEmpty()) {
>+    nsIDocument *document = OwnerDoc();
Nit, * goes with the type. Same also elsewhere.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Domenic, have you tested how action or formaction is reflected in different browsers when pushState has been used?

Comment 6

[Domenic Denicola]

Nope. Web platform test contributions would be great in that area.

Comment 7

[Jessica Jong [:jessica] (inactive)]

Attachment: Part 1: add GetAction and GetFormAction implementation, v1.

Fixed nits: * goes with the type. Carrying r+.

Comment 8

[Jessica Jong [:jessica] (inactive)]

Attachment: Part 1: add GetAction and GetFormAction implementation, v1.

Attaching the right patch. :/

Comment 9

[Jessica Jong [:jessica] (inactive)]

Attachment: Part 2: update related tests, v1.

Olli, could you take a look again? I added wpt for pushState cases. Note that wpt for form.action has not been merged into our codebase yet, so I didn't add tests for it.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8886072 [details] [diff] [review]
Part 2: update related tests, v1.

Is there wpt for .action and pushState?

Comment 11

[Jessica Jong [:jessica] (inactive)]

(In reply to Olli Pettay [:smaug] from comment #10)
> Comment on attachment 8886072 [details] [diff] [review]
> Part 2: update related tests, v1.
> 
> Is there wpt for .action and pushState?

wpt for .action with/without @action (the ones in comment 0) hasn't been merged into our codebase yet, so I didn't add them.

Comment 12

[Jessica Jong [:jessica] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=387678da52c472b0bd55df3e8c21bc53d7d66707&group_state=expanded

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c1a86e1296b
Part 1: .action/formAction should return the document's URL if @action/formaction is missing or empty. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f7663ac2068
Part 2: Update reflectURL() and web platform tests. r=smaug

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1c1a86e1296b
https://hg.mozilla.org/mozilla-central/rev/8f7663ac2068

Comment 16

[Chris Mills [:cmills]]

I've added notes to the relevant MDN pages to detail this change:

https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/API/HTMLButtonElement#Browser_compatibility
https://developer.mozilla.org/en-US/Firefox/Releases/56#DOM

Let me know if that is OK. Thanks!

Comment 17

[Kohei Yoshino]

It's a bit late but posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2017/html-form-s-action-property-now-returns-document-url-if-action-attribute-is-empty-or-missing/

Given that only 1 real issue has been reported so far, I think we can simply move it to Tech Evangelism rather than restoring the previous behaviour.